Border issues in nightly versus release (W11)

[hemirt]

Checklist

• I'm reporting a problem with Chatterino
• I've verified that I'm running the most recent nightly build or stable release
• I've looked for my problem on the wiki
• I've searched the issues and pull requests for similar looking reports

Describe your issue

If Windows 11 users could confirm how it appears for them, that would be nice, since this could just be some weird W11 setting combination.

windows 11 has these stupid borders around everything, they also change colors when window is selected or not (also whether its pinned to the side or not)

• some apps do NOT change these colors when active vs inactive (this would be preferred for me, would be nice to be a setting)

in stable it is that way, stays the same as active border whether the window is active or not
in nightly this is no longer that way, and it switches between inactive and active border states

the main issue is now that there is a small margin around chatterino nightly which looks bad, also the input box is smaller (for some reason the font in the input box too)

both unselected:

stable selected:

nightly selected:

as you can see, there is something off about the borders in nightly version, on windows 11

what can be problematic about this issue

• windows has like several settings affecting borders, border accents, colors, states, pin states, etc, so the way people see this can be different for everyone, so this may just be affecting a certain combination of settings that I have, so if anyone can also confirm if they see the same issues, that would be nice
• • that said, the chat input box should be the same (i.e. not filling up to the borders) for each user, if anyone could confirm here I zoomed in (and selected the nightly version, so that both versions have the same active border color, stable is in the top right back, whilst nightly is in front bottom left)

(I tried to disable windows scaling, and restart apps, still same issue, so atleast it shouldnt be specific to scaling issues)

Screenshots

No response

OS and Chatterino Version

Chatterino 2.5.1 (commit eafcb941) built with Qt 6.5.0, MSVC 193833135
Running on Windows 11 Version 24H2, kernel: 10.0.26120

Chatterino Nightly 2.5.1 (commit 64864a09) built on 2024-10-12 with Qt 6.7.1, MSVC 194134120, Crashpad
Running on Windows 11 Version 24H2, kernel: 10.0.26120

[hemirt]

If anyone can confirm that these issues exist, I can see that the Qt version changed, so that might give some directions.

[Nerixyz]

Can you try compiling Chatterino with the following line as auto addBorders = isMaximized (without the win11 check)?

chatterino2/src/widgets/BaseWindow.cpp

Line 124 in 64864a0

auto addBorders = isMaximized || isWindows11OrGreater();

[hemirt]

Can you try compiling Chatterino with the following line as auto addBorders = isMaximized (without the win11 check)?

chatterino2/src/widgets/BaseWindow.cpp

Line 124 in 64864a0

auto addBorders = isMaximized || isWindows11OrGreater();

trying out

[hemirt]

as you said with = isMaximized;, in the normal nonmaximized window now the border is not changing and is acting as it was before, i.e. always active state, i.e. same as the stable version

there is still a gap, but smaller than what is there without this change ->

(last two images are without the change, and the very first image in this comment is with the change)

sorry for using black as border color 😅 it makes it a bit difficult to see

[Nerixyz]

(I'm on Windows 10). We're "manually" drawing a border currently:

chatterino2/src/widgets/BaseWindow.cpp

Lines 1032 to 1042 in 64864a0

	// Draw a border that's exactly 1px wide
	//
	// There is a bug where the border can get <dpr>px wide while dragging.
	// this "fixes" itself when deselecting the window.
	auto dpr = this->devicePixelRatio();
	if (dpr != 1)
	{
	painter.setTransform(QTransform::fromScale(1 / dpr, 1 / dpr));
	}
	painter.fillRect(1, 1, this->realBounds_.width() - 2,
	this->realBounds_.height() - 2, bg);

... which is why we're setting margins of 1 (device independent pixels, not real pixels) [are you on a High-DPI screen?] We can't really have a 1px border since Qt uses integers for dp.

chatterino2/src/widgets/BaseWindow.cpp

Line 352 in 64864a0

this->ui_.layoutBase->setContentsMargins(1, 0, 1, 1);

On Windows 10, I find it nice to have the border change when selected/deselected. Since I'm not familiar with Windows 11, I don't know what the default behavior is.

[hemirt]

If anyone can confirm that these issues exist, I can see that the Qt version changed, so that might give some directions.

did try this out with qt 6.5.3., the input box gap is still there and the active/inactive things works the same as I mentioned when changing that line as you said, therefore I don't think qt version has anything to do with it

[hemirt]

Not sure what you mean by high dpi screen, but if you do mean windows scaling then yes, i have 150 % (with res: 2560x1440), I changed scaling to 100% for these images
without change:


(do still bear in mind that the black color is my accent color)

with change:

the gap persists, the active/inactive behaviour is as I mentioned before, I myself prefer the always active for chatterino, it is just a bit too jarring to see the border accent change - since I would prefer no border, alas, windows 11 deems that border must be, then border must be, no way to remove them.

[hemirt]

To summarize then:

1. So I guess the main issue I have is that the input box is not filled fully to the sides of the window (i dont like it this way because now it looks like a rectangle box is cut off by the rounded window corner.

2. And the fact that this might be a preferred setting, as you said you like the select/deselect thing in windows 10, whilst in windows 11 I dont like this (I think its due to the fact that borders exist even for deselected windows, I don't think windows 10 did this.).