Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis shouldn't be scaled #5684

Open
4 tasks done
Nerixyz opened this issue Oct 30, 2024 · 1 comment
Open
4 tasks done

Emojis shouldn't be scaled #5684

Nerixyz opened this issue Oct 30, 2024 · 1 comment

Comments

@Nerixyz
Copy link
Contributor

Nerixyz commented Oct 30, 2024

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

Currently, we scale emojis down from 64x64 to (about) 22x22. Downscaling is pretty bad with Qt (yes, even when SmoothPixmapTransform is enabled). We shouldn't have to do that since we (not really we, but pajlada) provide the emojis. We should scale the emojis once to the desired size(s) and distribute these. emoji-data provides a good foundation for this (imgmagik → zopfli).

Screenshots

No response

OS and Chatterino Version

@Nerixyz Nerixyz added the issue-report An issue reported by a user. label Oct 30, 2024
@pajlada pajlada added enhancement and removed issue-report An issue reported by a user. labels Oct 30, 2024
@pajlada
Copy link
Member

pajlada commented Nov 2, 2024

For pre-scaled sized, I imagine it'd be best for us to decide on an emoji size that isn't 22px.
I'm thinking 24px to begin with, or maybe 32px.
32px would be easier to scale for most emoji sets, but it's also kind of big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants