-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter: detect unused dependencies #221
Comments
A tool we can use: https://www.npmjs.com/package/depcheck |
@bajtos I want to work on this issue. Can you specify exactly on which repository you want to implement this. |
Awesome! We will want to eventually implement this in all https://github.com/CheckerNetwork/ repositories that have a Let's start with https://github.com/CheckerNetwork/spark-evaluate/ so that we can align on the proposed solution (please wait for an approval from @juliangruber @pyropy @NikolasHaimerl @bajtos). Some repositories like spark-api use npm workspaces, so there is more than one |
We should have a linting step to report unused dependencies, so that we don't have to discuss this in pull requests.
See e.g. https://github.com/filecoin-station/deal-observer/pull/12/files#r1924916463 and CheckerNetwork/spark-deal-observer#12 (comment)
The text was updated successfully, but these errors were encountered: