Use correct user when determining max repo limits for error messages (g…

…o-gitea#18153) - Use the correct user(`owner` instead of `ctx.User`) to get the maxCreationLimit.
Chianina · Mar 28, 2022 · 217dbb5 · 217dbb5
1 parent d5fb200
commit 217dbb5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/routers/web/repo/migrate.go b/routers/web/repo/migrate.go
@@ -82,7 +82,7 @@ func handleMigrateError(ctx *context.Context, owner *user_model.User, err error,
 		ctx.RenderWithErr(ctx.Tr("form.2fa_auth_required"), tpl, form)
 	case repo_model.IsErrReachLimitOfRepo(err):
 		var msg string
-		maxCreationLimit := ctx.User.MaxCreationLimit()
+		maxCreationLimit := owner.MaxCreationLimit()
 		if maxCreationLimit == 1 {
 			msg = ctx.Tr("repo.form.reach_limit_of_creation_1", maxCreationLimit)
 		} else {

diff --git a/routers/web/repo/repo.go b/routers/web/repo/repo.go
@@ -163,7 +163,7 @@ func handleCreateError(ctx *context.Context, owner *user_model.User, err error,
 	switch {
 	case repo_model.IsErrReachLimitOfRepo(err):
 		var msg string
-		maxCreationLimit := ctx.User.MaxCreationLimit()
+		maxCreationLimit := owner.MaxCreationLimit()
 		if maxCreationLimit == 1 {
 			msg = ctx.Tr("repo.form.reach_limit_of_creation_1", maxCreationLimit)
 		} else {

diff --git a/routers/web/repo/setting.go b/routers/web/repo/setting.go
@@ -609,7 +609,7 @@ func SettingsPost(ctx *context.Context) {
 		}
 
 		if !ctx.Repo.Owner.CanCreateRepo() {
-			maxCreationLimit := ctx.User.MaxCreationLimit()
+			maxCreationLimit := ctx.Repo.Owner.MaxCreationLimit()
 			if maxCreationLimit == 1 {
 				ctx.Flash.Error(ctx.Tr("repo.form.reach_limit_of_creation_1", maxCreationLimit))
 			} else {