Only create pprof files for gitea serv if explicitly asked for (go-gitea#18068)

zeripath · Stelios Malathouras · commit cde898d5de18 · 2022-03-28T15:45:34.000+03:00
diff --git a/cmd/serv.go b/cmd/serv.go
@@ -191,7 +191,7 @@ func runServ(c *cli.Context) error {
 		return fail("Invalid repo name", "Invalid repo name: %s", reponame)
 	}
 
-	if setting.EnablePprof || c.Bool("enable-pprof") {
+	if c.Bool("enable-pprof") {
 		if err := os.MkdirAll(setting.PprofDataPath, os.ModePerm); err != nil {
 			return fail("Error while trying to create PPROF_DATA_PATH", "Error while trying to create PPROF_DATA_PATH: %v", err)
 		}

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ func runServ(c *cli.Context) error {`
`191`	`191`	`return fail("Invalid repo name", "Invalid repo name: %s", reponame)`
`192`	`192`	`}`
`193`	`193`
`194`		`- if setting.EnablePprof \|\| c.Bool("enable-pprof") {`
	`194`	`+ if c.Bool("enable-pprof") {`
`195`	`195`	`if err := os.MkdirAll(setting.PprofDataPath, os.ModePerm); err != nil {`
`196`	`196`	`return fail("Error while trying to create PPROF_DATA_PATH", "Error while trying to create PPROF_DATA_PATH: %v", err)`
`197`	`197`	`}`