Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish between HTTP and remote schema errors #1063

Merged
merged 8 commits into from
Sep 10, 2019
Merged

Distinguish between HTTP and remote schema errors #1063

merged 8 commits into from
Sep 10, 2019

Conversation

nigel-sampson
Copy link
Contributor

Catches and attaches a specific error code to HttpRequestExceptions thrown in the stitching layer.

Resolves #1062

@michaelstaib michaelstaib self-requested a review September 9, 2019 12:40
@michaelstaib michaelstaib added this to the 10.1.0 milestone Sep 9, 2019
michaelstaib
michaelstaib approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@michaelstaib michaelstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you rebase it on version_10_0_0_master the we could add it to the fix release next week.

@nigel-sampson nigel-sampson changed the base branch from master to version_10_0_0_master September 10, 2019 02:14
@michaelstaib michaelstaib merged commit 17f1cdf into version_10_0_0_master Sep 10, 2019
@michaelstaib michaelstaib deleted the 1062-Http-Errors branch September 10, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@nigel-sampson nigel-sampson

Labels
None yet
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nigel-sampson @michaelstaib @gmiserez @rstaib