Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked how input object arguments are cached #805

Merged
merged 6 commits into from
Jun 2, 2019
Merged

Reworked how input object arguments are cached #805

merged 6 commits into from
Jun 2, 2019

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented May 31, 2019 •
edited
Loading

Fixes #803

@michaelstaib michaelstaib added this to the 9.0.0 milestone May 31, 2019
@michaelstaib michaelstaib self-assigned this May 31, 2019
@michaelstaib
Copy link
Member Author

michaelstaib commented May 31, 2019 •
edited
Loading

  • We have to update the resource texts.
  • We have to rework the object based validator
  • Check how we are validating the variable values (can we remove re-checking them when merging with the arguments?)
  • Add tests that proof that you cannot alter cached arguments

@michaelstaib michaelstaib changed the title Reworked how input object arguments are cached . Reworked how input object arguments are cached Jun 1, 2019
@michaelstaib michaelstaib merged commit cf6aab0 into master Jun 2, 2019
@michaelstaib michaelstaib deleted the argument_caching branch June 2, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelstaib michaelstaib

Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Argument Caching Issue
1 participant
@michaelstaib