Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement persistency option for application output variables #37

Open
killenb opened this issue May 23, 2019 · 2 comments
Open

Implement persistency option for application output variables #37

killenb opened this issue May 23, 2019 · 2 comments
Labels
redmine Issue tracked on DESY MSK Redmine

Comments

@killenb
Copy link
Member

killenb commented May 23, 2019

DeviceToControlSystem variables can conceptually not be presisted by the control system. The application has to take care of this in case the values cannot be re-calculated when re-starting the server.

Task: The Output should get an option to persist this variable (off by default). When enabled, the variable is always written to file when a write is called. When the application is started/initialised, the variable content is read from the file.

Details:

  • The implementation should happen with a decorator. Like this any output (to Device, Control System or to other ApplicationModules) can be saved and restored.
  • Make sure to flush the file after each write. Leave a comment in the code that this has to be tested manually by killing the application with -9 and check that the last value is restored correctly at server start. This kind of test is not well suited for an automated test.
@mhier
Copy link
Member

mhier commented Nov 26, 2019

I just hit another use case for this. My workaround now was to use an input with return channel instead and ignore any values written to that input. This could be another way of implementing this feature (of course while avoiding the quirks I have to use now), as it would allow to use the same persistency layer as for the input variables (i.e. the one from the control system).

@mhier
Copy link
Member

mhier commented Jun 16, 2021

Now on redmine #8362

@mhier mhier added the redmine Issue tracked on DESY MSK Redmine label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redmine Issue tracked on DESY MSK Redmine
Projects
None yet
Development

No branches or pull requests

2 participants