Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

own language of languages list items is not properly indicated thru attribute lang=".." #2786

Closed
ele-gall-ac-mineducation opened this issue May 25, 2020 · 1 comment

Comments

@ele-gall-ac-mineducation

What happened?

In the list of languages (i.e. in the main menu), each language item is written in its own language (which is OK). But it is read with the main language of the page or the voice synthesis own parameter if there's no one. Except for this language, the others aren't read with their own prononciation (Português is read Portugue/Portugues/Portuguez and not Portuguesch).

What do you expect to happen instead?

An attribute « lang=".." » with the code of the language:

<a [lang]="{{lang.id}}" *ngFor="let lang of languages" [href]="buildLanguageLink(lang)">{{ lang.label }} (or something like that as I don't know TS)

https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/menu/language-chooser.component.html#L13

Steps to reproduce:

  1. use https://ffoodd.github.io/a11y.css/ to diagnose

  2. in any page of PeerTube, open the language menu

  3. use a11y.css « Afficher les langues » in French (« Show languages » in English ?)

  4. no item has is language defined by lang attribute

Additional information

https://developer.paciellogroup.com/blog/2016/06/using-the-html-lang-attribute/

working example:

https://developer.mozilla.org/en-US/docs/Learn/Accessibility

screencaptures:
language bug mini
language nobug MDN

@rigelk rigelk changed the title [ a11y ] own language of languages list items is not properly indicated thru attribute lang=".." own language of languages list items is not properly indicated thru attribute lang=".." May 25, 2020
@Chocobozzz
Copy link
Owner

Fixed by @Pandoraaa in #2832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants