-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.3 upgrade: config loading error when loading admin page #4371
Comments
Oh yeah, here is our root@b5c9f675e1b4:/config# cat local-production.json
{
"instance": {
"name": "tv.lumbung.space",
"short_description": "A self-organized space for the lumbung inter-lokal",
"description": "Welcome to [tv.lumbung.space](https://tv.lumbung.space)!\n\nThis is all a big work in progress.\n\nWe'll have more soon.",
"is_nsfw": false,
"default_nsfw_policy": "do_not_list",
"terms": "No terms for now.",
"code_of_conduct": "",
"creation_reason": "",
"moderation_information": "",
"administrator": "",
"maintenance_lifetime": "",
"business_model": "",
"hardware_information": "",
"categories": [],
"languages": [],
"default_client_route": "/videos/local",
"customizations": {
"javascript": "",
"css": ""
}
},
"theme": {
"default": "default"
},
"services": {
"twitter": {
"username": "@foo",
"whitelisted": false
}
},
"cache": {
"previews": {
"size": 500
},
"captions": {
"size": 500
},
"torrents": {
"size": 500
}
},
"signup": {
"enabled": false,
"limit": 10,
"requires_email_verification": false
},
"import": {
"videos": {
"concurrency": 2,
"http": {
"enabled": true
},
"torrent": {
"enabled": true
}
}
},
"trending": {
"videos": {
"algorithms": {
"enabled": [
"best",
"hot",
"most-viewed",
"most-liked"
],
"default": "best"
}
}
},
"admin": {
"email": "foo@example.com"
},
"contact_form": {
"enabled": false
},
"user": {
"video_quota": -1,
"video_quota_daily": -1
},
"transcoding": {
"enabled": true,
"threads": 4,
"allow_additional_extensions": true,
"allow_audio_files": true,
"profile": "default",
"concurrency": 2,
"resolutions": {
"0p": false,
"240p": true,
"360p": false,
"480p": true,
"720p": true,
"1080p": false,
"1440p": false,
"2160p": false
},
"hls": {
"enabled": true
},
"webtorrent": {
"enabled": false
}
},
"live": {
"enabled": true,
"max_duration": 18000000,
"max_instance_lives": 20,
"max_user_lives": 3,
"allow_replay": true,
"transcoding": {
"enabled": true,
"threads": 4,
"profile": "default",
"resolutions": {
"240p": false,
"360p": false,
"480p": true,
"720p": false,
"1080p": false,
"1440p": false,
"2160p": false
}
}
},
"auto_blacklist": {
"videos": {
"of_users": {
"enabled": false
}
}
},
"followers": {
"instance": {
"enabled": false,
"manual_approval": false
}
},
"followings": {
"instance": {
"auto_follow_back": {
"enabled": false
},
"auto_follow_index": {
"enabled": false,
"index_url": ""
}
}
},
"broadcast_message": {
"enabled": true,
"level": "info",
"dismissable": true,
"message": "Welcome to **tv.lumbung.space**, bear with us as we're still setting everything up!"
},
"search": {
"remote_uri": {
"users": true,
"anonymous": true
},
"search_index": {
"enabled": false,
"url": "",
"disable_local_search": false,
"is_default_search": false
}
} |
Renaming |
Hello, It seems there was an issue in 3.3 migration script: |
@Chocobozzz is there a way I can run that migration script myself via |
https://tv.lumbung.space/api/v1/custom-pages/homepage/instance now works tho? 🤔 |
Please check your logs about this migration |
Feels to me that the potential bug is in the generation of the {
"instance": {
"name": "tv.lumbung.space",
"short_description": "...",
"description": "...",
"is_nsfw": false,
"default_nsfw_policy": "do_not_list",
"terms": "No terms for now.",
"code_of_conduct": "",
"creation_reason": "",
"moderation_information": "",
"administrator": "",
"maintenance_lifetime": "",
"business_model": "",
"hardware_information": "",
"categories": [],
"languages": [],
"default_client_route": "/videos/local",
"customizations": {
"javascript": "",
"css": "_ngcontent-jkj-c171 {\n display: none;\n}\n\n.external-login-blocks > div.block-title {\n display: none;\n}\n\n.title-page.title-page-single::after {\n content: \"with\";\n}\n"
}
},
"theme": {
"default": "default"
},
"services": {
"twitter": {
"username": "@foo",
"whitelisted": false
}
},
"cache": {
"previews": {
"size": 500
},
"captions": {
"size": 500
},
"torrents": {
"size": 500
}
},
"signup": {
"enabled": false,
"limit": 10,
"requires_email_verification": false,
"minimum_age": 16
},
"import": {
"videos": {
"concurrency": 1,
"http": {
"enabled": true
},
"torrent": {
"enabled": false
}
}
},
"trending": {
"videos": {
"algorithms": {
"enabled": [
"best",
"hot",
"most-viewed",
"most-liked"
],
"default": "most-viewed"
}
}
},
"admin": {
"email": "foo@example.com"
},
"contact_form": {
"enabled": false
},
"user": {
"video_quota": -1,
"video_quota_daily": -1
},
"transcoding": {
"enabled": true,
"threads": 2,
"allow_additional_extensions": true,
"allow_audio_files": true,
"profile": "default",
"concurrency": 1,
"resolutions": {
"0p": true,
"240p": false,
"360p": true,
"480p": false,
"720p": true,
"1080p": false,
"1440p": false,
"2160p": false
},
"hls": {
"enabled": true
},
"webtorrent": {
"enabled": false
}
},
"live": {
"enabled": true,
"max_duration": 18000000,
"max_instance_lives": 20,
"max_user_lives": 3,
"allow_replay": true,
"transcoding": {
"enabled": true,
"threads": 4,
"profile": "default",
"resolutions": {
"240p": false,
"360p": false,
"480p": true,
"720p": false,
"1080p": false,
"1440p": false,
"2160p": false
}
}
},
"auto_blacklist": {
"videos": {
"of_users": {
"enabled": false
}
}
},
"followers": {
"instance": {
"enabled": true,
"manual_approval": true
}
},
"followings": {
"instance": {
"auto_follow_back": {
"enabled": false
},
"auto_follow_index": {
"enabled": false,
"index_url": ""
}
}
},
"broadcast_message": {
"enabled": true,
"level": "info",
"dismissable": false,
"message": "..."
},
"search": {
"remote_uri": {
"users": true,
"anonymous": false
},
"search_index": {
"enabled": false,
"url": "",
"disable_local_search": false,
"is_default_search": false
}
}
} |
The migration seems to have been a success, and there is nothing wrong with the local configuration. Closing this issue since the homepage (https://tv.lumbung.space/api/v1/custom-pages/homepage/instance ) seems to work as expected. I also fixed a config bug in b4c945f but I don't think it's related to your issue. |
Hi @Chocobozzz, that is not completely true because we ended up setting the vanilla config and I just entered the values through the interface by hand since we needed to use the instance. So it might mean that the migration still does not work properly, just a fyi! |
Describe the current behavior
When loading the admin page, there is an error shown. It looks to be a configuration breakage but I would expect a v3.2 -> v3.3 to not break configs.
Steps to reproduce:
You provided 'undefined' where a stream was expected. You can provide an Observable, Promise, Array, or Iterable.
Uncaught SyntaxError: Unexpected identifier
,Cannot load config locally. Fallback to API.
,Failed to load resource: the server responded with a status of 500 ()
,main.c9eac874d7bd3b1cbab9.js:3 Backend returned code 500, errorMessage is: relation "actorCustomPage" does not exist
and thenmain.c9eac874d7bd3b1cbab9.js:3 Backend returned code 500, errorMessage is: relation "actorCustomPage" does not exist
{"type":"https://docs.joinpeertube.org/api-rest-reference.html#section/Errors/SequelizeDatabaseError","detail":"relation \"actorCustomPage\" does not exist","status":500,"code":"SequelizeDatabaseError","error":"relation \"actorCustomPage\" does not exist"}
Digging a bit further, I found that it is trying to load the following before it goes to the API:
I can't quite spot the error?
Here is our production deployment configuration: https://git.coopcloud.tech/coop-cloud/peertube/src/branch/main/compose.yml where we are using the env var substitution functionality. It seem the only change to that has been #4290? I made sure our
custom-environment-variables.yml
is up to date.We upgraded from the
v3.2.1-buster
imageDescribe the expected behavior
Additional information
PeerTube instance:
Browser name, version and platforms on which you could reproduce the bug: chrome latest stable
Link to browser console log if relevant: (provided above)
Link to server log if relevant (
journalctl
or/var/www/peertube/storage/logs/
): no error seenThe text was updated successfully, but these errors were encountered: