Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support copy codecs in peertube runner #6539

Open
ilfarpro opened this issue Aug 7, 2024 · 0 comments
Open

Support copy codecs in peertube runner #6539

ilfarpro opened this issue Aug 7, 2024 · 0 comments

Comments

@ilfarpro
Copy link

ilfarpro commented Aug 7, 2024

Describe the current behavior

I'm sorry. this could be not a bug or maybe just not implemented yet...

When I use Peertube without runner it can do job optimize-to-web-video and next to it new-resolution-to-hls job with "copyCodecs": true option. Peertube runner can't do that for some reason. It leads to significant increase in time because runner should encode original resolution 2 times:

  1. to optimize video to web (highest resolution)
  2. encode highest resolution again

Please take a look at screenshosts to see more.

This is how Peertube without runner behaves. It can copy codecs and save a ton of time.
no-double-transcoding

But Peertube runner encodes 2 times the same resolution and it takes 2x time.
double encoding

Maybe it's related to this line of code.

Steps to reproduce

  1. Install latest peertube runner
  2. Uload a video
  3. Transcode that video :)

Describe the expected behavior

I expect peertube runner to copy codecs for highest resolution when it does it's HLS version. Peertube already can do that, let's make runner be able to do it too, please 🙏

Additional information

  • PeerTube instance:
    • Version: 6.2.1
    • NodeJS version: v20.16.0
    • Ffmpeg version: 7.0.1
@Chocobozzz Chocobozzz changed the title Peertube runner transcodes highest resolution 2 times Support copy codecs in peertube runner Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants