Plugins modules are not correctly unloaded on uninstall (or updates)

[JohnXLivingston]

Describe the current behavior

While working on new plugins, I have sometimes weird behaviors that requires a peertube restart.
I thinks that it is because of these lines:

PeerTube/server/lib/plugins/plugin-manager.ts

Lines 413 to 415 in 0564fc0

	const modulePath = join(pluginPath, packageJSON.library)
	delete require.cache[modulePath]
	const library: PluginLibrary = require(modulePath)

Plugins are unloaded using:

delete require.cache[modulePath]

But if they are requires in the module main file, it will not be unloaded.

So, when you update your module code, it will mix old and new modules.

Describe the expected behavior

Plugin imported files should be unloaded too.
I think this module can help: https://www.npmjs.com/package/decache

Additional information

• PeerTube instance:
  • version: 3.1.0
  • NodeJS version: 12

[JohnXLivingston]

I can confirm that this workaround is working with my plugin:
JohnXLivingston/peertube-plugin-livechat@0bad31d

Without it, changes in my settings names are not visible unless I restart the server. With the call to decache, everything works fine.

[JohnXLivingston]

@Chocobozzz , tell me if you want me to make a PR with a fix.

[Chocobozzz]

tell me if you want me to make a PR with a fix.

Yes please 👍

[JohnXLivingston]

For the record, I found a similar potential bug in server/initializers, function reloadConfig.
Have you ever had a cache bug when reloading config? Maybe we should apply the same fix?

[Chocobozzz]

Have you ever had a cache bug when reloading config?

No we haven't, but it safer to use decache here too

[JohnXLivingston]

Ok, i'll do the PR.