Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 RM #2

Open
solomon23 opened this issue Jan 2, 2018 · 5 comments
Open

1 RM #2

solomon23 opened this issue Jan 2, 2018 · 5 comments

Comments

@solomon23
Copy link

Would be neat if the app tracked your calculated one rep max per session

@Chris-Perkins
Copy link
Owner

Chris-Perkins commented Jan 2, 2018

Would this be a property stored per exercise, or something displayed afterward in the summary table?
What could be done is display the max per progression method and display this in the exercise view's cells

@solomon23
Copy link
Author

I would be interesting per set. And also the highest per session so it could be graphed.

If day 1 I did 10 reps at 100 and day 2 I did 8 reps at 125. I’d like to see a graph of my one rep max comparing those two sessions. Total load would be interesting as well

@Chris-Perkins
Copy link
Owner

Chris-Perkins commented Jan 2, 2018

Highest per session may be more difficult to implement in retrospect based on the current way the history is set up. Currently, the history is grouped into one list and there is no way of grouping history entries entered in the same session.

This change would take some architectural planning.
In the mean time, graphing should let you see your peaks per session which would inadvertently (but un-optimally) address seeing your one-rep max per exercise.

Your issue also gave me the idea of graphing your current session vs. the x most recent entries. I think the user might enjoy that.

EDIT: Clarifying question based on "If day 1 I did 10 reps at 100 and day 2 I did 8 reps at 125. I’d like to see a graph of my one rep max comparing those two sessions."
How is this 1-rep max being calculated? Estimation?

@solomon23
Copy link
Author

Yea, there's a few places that calculate you're one rep max - https://www.bodybuilding.com/fun/other7.htm. Not sure the definitive formula, but i'm guessing there are some out there

Ideally it would be something like this
Add Set
insert reps
inserts weight
click complete

you're told your total Volume for the set
you're told your estimated one rep max for the set
maybe get a rest counter

you're also told your one rep max for the exercise ( using your highest set )
you're also told your one set volume max for the exercise ( using your highest set )
also listed the total volume you've done for all sets

then given that data ideally you would be shown your previous one rep max and if you've beaten it this set
same with volume per set and total set
it's also a good opportunity for fun animations when you beat your previous best
it's also a good way to set goals. ie.. i could input my goal is hit a 1RM of 155 on a particular exercise. Hitting the extra rep that one set might get me there without realizing it. the app showing me some celebration animations would be super motivating

obviously what motivates me when working out is numbers. I wanna know what various numbers and if i'm beating them this session.

For how to architect history i would just record everything the user inputs and then worry about graphing it different ways on the way out

@Chris-Perkins
Copy link
Owner

Ah! Great points.

I will add one-rep maxes/total volume to the workout summary. This feature will be held exclusively for exercises with weight/rep progressionmethods which should be a fairly large margin of the use cases.

I did plan on adding fun animations, but I wanted to make the app more functional before I do any dolling up. As soon as I feel comfortable (I can't really give a timeframe on this as school is starting soon), expect to see more and more animations pop up in the app.

I'll comment on this thread as more progress is made. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants