Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor event_listener.py #153

Open
ChrisNeedham24 opened this issue Sep 22, 2024 · 1 comment
Open

Refactor event_listener.py #153

ChrisNeedham24 opened this issue Sep 22, 2024 · 1 comment
Labels
refactor No new functionality

Comments

@ChrisNeedham24
Copy link
Owner

Yes, I know it was only just made in #150 but it could definitely be improved. The main two ways I can see this going are to split RequestHandler and EventListener into their own files, and potentially going even further, to split a sort of UpdateHandler out of RequestHandler.
@ChrisNeedham24 ChrisNeedham24 added the refactor No new functionality label Sep 22, 2024
@ChrisNeedham24
Copy link
Owner Author

Could also get even more tricky and extract game state modification out of both EventListener and GameState into some common file, but that would understandably be quite difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor No new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisNeedham24