Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with .get in MacroCalcService making values mandatory #45

Open
Christian-QA opened this issue Jan 24, 2022 · 0 comments
Open

Fix issue with .get in MacroCalcService making values mandatory #45

Christian-QA opened this issue Jan 24, 2022 · 0 comments

Comments

@Christian-QA
Copy link
Owner

Christian-QA commented Jan 24, 2022 •
edited
Loading

In MacroStatService.scala, the method addMacroStat on Ln61 uses .get on values which are supposed to be optional. The reason for this was that I wanted to complete the method as it was blocking other issues, but the uJson documentation regarding this was vague.

Now that the services and controllers are ready to be connected, this issue needs to be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Christian-QA