Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is refresh=True the default? #138

Open
diwu1989 opened this issue Dec 17, 2015 · 1 comment
Open

why is refresh=True the default? #138

diwu1989 opened this issue Dec 17, 2015 · 1 comment

Comments

@diwu1989
Copy link
Contributor

in update_index and delete_index_item, why is it forcing index refresh by default?

I think API wise, it should be refresh=False to match default elastic search behavior, for obvious performance reasons in a cluster setup (or better yet we just separate this responsibility out and make the caller handle refreshes)

Issuing the refresh on an index is as simple as a single API call, so I propose we get rid of the refresh logic and make the outside caller make their own judgement call of when to call refresh if necessary

if you agree then I can submit the pull request for this change

@ChristopherRabotin
Copy link
Owner

The refresh flag is set to True to avoid having to call it after indexing, and for the newly indexed items to be available immediately. However, I understand how that can affect performance on large indices.

Instead of just switching it to False, I think a better solution is to have it in the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants