You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in update_index and delete_index_item, why is it forcing index refresh by default?
I think API wise, it should be refresh=False to match default elastic search behavior, for obvious performance reasons in a cluster setup (or better yet we just separate this responsibility out and make the caller handle refreshes)
Issuing the refresh on an index is as simple as a single API call, so I propose we get rid of the refresh logic and make the outside caller make their own judgement call of when to call refresh if necessary
if you agree then I can submit the pull request for this change
The text was updated successfully, but these errors were encountered:
The refresh flag is set to True to avoid having to call it after indexing, and for the newly indexed items to be available immediately. However, I understand how that can affect performance on large indices.
Instead of just switching it to False, I think a better solution is to have it in the settings.
in update_index and delete_index_item, why is it forcing index refresh by default?
I think API wise, it should be refresh=False to match default elastic search behavior, for obvious performance reasons in a cluster setup (or better yet we just separate this responsibility out and make the caller handle refreshes)
Issuing the refresh on an index is as simple as a single API call, so I propose we get rid of the refresh logic and make the outside caller make their own judgement call of when to call refresh if necessary
if you agree then I can submit the pull request for this change
The text was updated successfully, but these errors were encountered: