Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bungiesearch support for ES2.0+ #148

Open
jjhuang opened this issue Mar 30, 2016 · 0 comments
Open

Bungiesearch support for ES2.0+ #148

jjhuang opened this issue Mar 30, 2016 · 0 comments
Milestone

Comments

@jjhuang
Copy link
Contributor

jjhuang commented Mar 30, 2016

Hi, are there plans for a version of Bungiesearch that supports ES2.x? I've attempted to run Bungiesearch on the latest Elasticsearch (2.2.1) and have identified a few minor fixes that need to be made to support this (though there's possibly more):

As far as I can tell, the above two changes were the "main" things that prevent Bungiesearch from being compatible with both the newer Elasticsearch server as well as newer versions of elasticsearch-dsl.

I originally planned to make this PR, but discovered that all the Bungiesearch tests failed completely due to the new 2.0 restriction where types that exist in the same index can no longer have fields with the same name IF the mappings are different. In the tests, there are numerous models that share fields such as description, title or updated yet use differing mappings. So, either the mappings need to be unified or the field names have to be changed. I'm not too keen about submitting a PR that hacks up the test files especially since I don't have full knowledge of the intended coverage.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants