-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileNotFoundException drops the request #394
Comments
I considered whether this should be wrapped in a chucker/library/src/main/java/com/chuckerteam/chucker/internal/support/TeeSource.kt Line 27 in a6ed2d4
In my opinion, the issue should be reported to this third-party vendor as a bug. However, I also understand where are you coming from. We could ignore the processing body of requests which fail to create a file. @vbuberen @cortinico what do you think? Do you see a need for some special message for requests that fail for this reason? Personally I don't think so as from my perspective it is the same as any IO failure during writes or reads from a file. On the other hand, it might be harder in the future to analyze similar issues. Maybe there should be some UI to indicate this type of errors? |
Ideally that should be the right thing to do.
How about printing the stacktrace with some extra message? That will help at least debugging once we get users reporting those kind of issues. |
Guys, I tried 3.3.0-SNAPSHOT version and haven't received FileNotFoundException again. But now I'm receiving another exception in the same place:
It happens even after removing the application from device and reinstalling a new one. |
Well… that's not cool. Does it happen for all requests or only for some of them as well? @cortinico @vbuberen FYI - don't know if you'd like to reopen this issue or create a new one (technically it is a different thing). |
Yes, we should open a new issue. I will handle it. |
@CodeBreak524 I invite you to the new issue to provide more info. |
After performing one of the requests in my app I receive that kind of error which results in failed request:
Repeating the same request doesn't solve this problem, but performing a different request does.
💣 Steps to reproduce
It happens after giving the control off app to another third-party library. I cannot tell you more concrete info because I really don't know what happens inside this library. Maybe it clears all caches of app which then results in Chucker error.
🔧 Expected behavior
Anyway it seems that dropping the request with internal error is not the best option. A warning should be enough even though the request wouldn't be logged.
Tech info - different devices, different OS versions
The text was updated successfully, but these errors were encountered: