Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request size is shown as -1 #714

Closed
vbuberen opened this issue Nov 2, 2021 · 3 comments
Closed

Request size is shown as -1 #714

vbuberen opened this issue Nov 2, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@vbuberen
Copy link
Collaborator

vbuberen commented Nov 2, 2021

✍️ Describe the bug

POST request size for requests without payload shows invalid value -1 in the version from develop branch

💣 Steps to reproduce

  1. Do some POST requests without payload
  2. Open transaction details

🔧 Expected behavior

Request size is shown as 0 or -

📷 Screenshots

Screenshot 2021-11-02 at 11 59 24

📄 Additional context

I suspect this issue appeared after merging #696

@vbuberen vbuberen added the bug Something isn't working label Nov 2, 2021
@MiSikora
Copy link
Contributor

MiSikora commented Nov 2, 2021

I can take a look at it.

@MiSikora
Copy link
Contributor

MiSikora commented Nov 2, 2021

This bug wasn't introduced with #696. It is a result of not processing one-shot bodies added in #544.

postRawRequestBody(oneShotRequestBody()).enqueue(noOpCallback)

if (body.isOneShot()) {
Logger.info("Skipping one shot request body")
return
}

Let's deal with it during #570. I'll update the description there, and I think we can close this one. Do you agree?

@vbuberen
Copy link
Collaborator Author

vbuberen commented Nov 2, 2021

Yep, absolutely. Closing.

@vbuberen vbuberen closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants