Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untranslated terms in 2.30-RC1: #1207

Closed
saulowulhynek opened this issue Oct 24, 2016 · 14 comments · Fixed by #1335
Closed

Untranslated terms in 2.30-RC1: #1207

saulowulhynek opened this issue Oct 24, 2016 · 14 comments · Fixed by #1335

Comments

@saulowulhynek
Copy link

In Group List:

Show X entries
Group Name
members
Group Cart Status
Group Type
Showing X to X of X entries
Previus
Next

In Sundy School, in dashboard (2 times):
Show X entries
Search:
No data available in table
Showing X to X of X entries
Previus
Next

In Sundy School, in class list:

Show X entries
Search:
Copy
Print
No data available in table
Showing X to X of X entries
Previus
Next

In group editor:
"New"

In Event List:
All

In Fundraiser, View All Deposit
Deposit Comment
Show X entries
Search:
Deposit ID
Deposit Date
Deposit Total
deposit Comment
Closed
Deposit Type
No data available in table
Showing X to X of X entries
Previus
Next

@DawoudIO
Copy link
Contributor

I'll check it out but it feels like you are talking about the table plugin we are using here is to hope it has built in locale support

@saulowulhynek
Copy link
Author

But I don't found some term as "Show" "entries" in messages.po (inside pt-br)

@saulowulhynek
Copy link
Author

I found and add gettext to:

FindDepositSlip.php:69 : "Deposit Comment"
OptionsManager.php:386 : "New"
ListEvents.php:93 : "All"

@saulowulhynek
Copy link
Author

I found too:

email/Dashboard.php: 37 :"import subscribers to a list."
email/Dashboard.php: 95 : "MailChimp is not configured"
email/Dashboard.php: 96 :"Please update the MailChimp API key in Setting->"
email/Dashboard.php: 96 : "Edit General Settings"
email/Dashboard.php: 97 : "then update mailChimpApiKey. For more info see our "
email/Dashboard.php: 97 : "MailChimp support docs."

@DawoudIO
Copy link
Contributor

Good finds we need to remove mailchimp as text as it is will not change from translation to another

@saulowulhynek
Copy link
Author

FamilyView.php :172: "Address: "

@saulowulhynek
Copy link
Author

ok, I will remake gettexts without MailChimp strings.

@DawoudIO DawoudIO added this to the 2.3.0 milestone Oct 26, 2016
@DawoudIO
Copy link
Contributor

@saulowulhynek for groupList.php you can add gettext around the "title:" in the JS

ie

{
        width: 'auto',
        title: 'Group Cart Status',
        searchable: false,
        render: function (data, type, full, meta) {
          return '<span class="cartStatusButton" data-groupid="'+ full.Id + '">Checking Cart Status</span>';

        }
      },

to

{
        width: 'auto',
        title: '<?= gettext("Group Cart Status")?>',
        searchable: false,
        render: function (data, type, full, meta) {
          return '<span class="cartStatusButton" data-groupid="'+ full.Id + '"><?= gettext("Checking Cart Status")?></span>';

        }
      },

@DawoudIO
Copy link
Contributor

as for the table nav items we need to use DataTable plugin see #1141

@DawoudIO
Copy link
Contributor

DawoudIO commented Nov 7, 2016

outside the datatable plugin which is tracked in #1237 can we close this one.... is everything else done.

@DawoudIO
Copy link
Contributor

image

@DawoudIO
Copy link
Contributor

I think i got all but "In Fundraiser, View All Deposit" can you give me the page URL

@saulowulhynek
Copy link
Author

Sorry: The text was

In Fundraiser:
a) View All Deposits in FindDepositSlip.php
fundraiser_translate

@DawoudIO
Copy link
Contributor

Great I'll make that change also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants