Bug: Updating to 5.12.0 seems to break things

[dleigh]

Description

A clear and concise description of what the reported bug is: I tried the built-in upgrade process from 5.6.0 to 5.12.0. It failed and mentioned a Slim Application error (don't remember the message exactly). When I logged in after that it had me update the database. The main dashboard was missing lots of stuff and the calendar didn't display and the map of people doesn't display, etc.. So I did the manual update of downloading the zip and overwriting the files and then updating the permissions. I then logged in but nothing had changed with those issues. So I went to the Administration section of the application to try and look around and it crashed. Here's the Slim Application error info.

`Slim Application Error

The application could not run because of the following error:
Details
Type: TypeError
Code: 0
Message: ChurchCRM\Service\AppIntegrityService::getIntegrityCheckMessage(): Return value must be of type string, null returned
File: /home/ejadmin/sites/churchcrm/ChurchCRM/Service/AppIntegrityService.php
Line: 75
Trace

#0 /home/ejadmin/sites/churchcrm/v2/templates/admin/debug.php(197): ChurchCRM\Service\AppIntegrityService::getIntegrityCheckMessage()
#1 /home/ejadmin/sites/churchcrm/vendor/slim/php-view/src/PhpRenderer.php(219): include('/home/ejadmin/s...')
#2 /home/ejadmin/sites/churchcrm/vendor/slim/php-view/src/PhpRenderer.php(184): Slim\Views\PhpRenderer->protectedIncludeScope()
#3 /home/ejadmin/sites/churchcrm/vendor/slim/php-view/src/PhpRenderer.php(152): Slim\Views\PhpRenderer->fetchTemplate()
#4 /home/ejadmin/sites/churchcrm/vendor/slim/php-view/src/PhpRenderer.php(53): Slim\Views\PhpRenderer->fetch()
#5 /home/ejadmin/sites/churchcrm/v2/routes/admin/admin.php(25): Slim\Views\PhpRenderer->render()
#6 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(38): debugPage()
#7 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/Routing/Route.php(363): Slim\Handlers\Strategies\RequestResponse->__invoke()
#8 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(73): Slim\Routing\Route->handle()
#9 /home/ejadmin/sites/churchcrm/ChurchCRM/Slim/Middleware/Request/Auth/BaseAuthRoleMiddleware.php(29): Slim\MiddlewareDispatcher->handle()
#10 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(177): ChurchCRM\Slim\Middleware\Request\Auth\BaseAuthRoleMiddleware->__invoke()
#11 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(73): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#12 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/Routing/Route.php(321): Slim\MiddlewareDispatcher->handle()
#13 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/Routing/RouteRunner.php(74): Slim\Routing\Route->run()
#14 /home/ejadmin/sites/churchcrm/ChurchCRM/Slim/Middleware/VersionMiddleware.php(14): Slim\Routing\RouteRunner->handle()
#15 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(177): ChurchCRM\Slim\Middleware\VersionMiddleware->__invoke()
#16 /home/ejadmin/sites/churchcrm/ChurchCRM/Slim/Middleware/AuthMiddleware.php(36): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#17 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(177): ChurchCRM\Slim\Middleware\AuthMiddleware->__invoke()
#18 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/Middleware/BodyParsingMiddleware.php(65): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#19 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(129): Slim\Middleware\BodyParsingMiddleware->process()
#20 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/Middleware/ErrorMiddleware.php(77): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#21 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(129): Slim\Middleware\ErrorMiddleware->process()
#22 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/MiddlewareDispatcher.php(73): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#23 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/App.php(209): Slim\MiddlewareDispatcher->handle()
#24 /home/ejadmin/sites/churchcrm/vendor/slim/slim/Slim/App.php(193): Slim\App->handle()
#25 /home/ejadmin/sites/churchcrm/v2/index.php(43): Slim\App->run()
#26 {main}`

I then tried to use the in-app bug reporting but when I clicked on "Submit to GitHub" nothing happens at all.

The data on individual people all seems to be there but lots of stuff doesn't seem to work.

• ChurchCRM version: [e.g. 5.12.0]
• PHP version the server running: [e.g. PHP 8.1.31 ]
• DB Server and Version the server is running: [e.g. 10.0.38-MariaDB]

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[dleigh]

Any thoughts of how to resolve this?

[DAcodedBEAT]

The fix to this (b485bc8) is awaiting release @DawoudIO

[dleigh]

Good to hear. Thanks.

[DawoudIO]

In that case let me do it now

[DawoudIO]

Ok released can you test now please.

[dleigh]

Ok, so it updated to 5.13.0 without any messages but once I'm logged in, there are still lots of missing functionality, like:

• creating a bug report from within churchcrm doesn't work
• the calendar doesn't show up at all
• the map of members doesn't show up at all
• on the dashboard, on the bottom half, I'm used to lots of different info being there and it's empty now (screenshot attached)
• the filters are missing in the list of people

I've attached my application logs for today as well.

2025-01-17-CRM.zip