Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider branch-per-directory structure #4

Open
calvn opened this issue Jun 13, 2016 · 0 comments
Open

Consider branch-per-directory structure #4

calvn opened this issue Jun 13, 2016 · 0 comments
Labels

Comments

@calvn
Copy link
Contributor

calvn commented Jun 13, 2016

[node-]git2consul uses a branch/tag per directory structure when cloning repository to its local cache. Having such design allows for reduced complexity as the cost of increased disk space usage. Additionally, having branch-per-directory gives us the ability for git2consul to sync up branches from a single repository concurrently.

Currently, polling is done synchronously with mutex lock so that the head can be kept in sync during KV read/write. If a particular checkout consumes a lot of time, this can affect the performance of git2consul, as it is a blocking call when polling for each branch.

@calvn calvn added the thinking label Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant