Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Resource Tags #120

Closed
dgeorges opened this issue Feb 9, 2021 · 2 comments
Closed

Support Resource Tags #120

dgeorges opened this issue Feb 9, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dgeorges
Copy link
Contributor

dgeorges commented Feb 9, 2021

What would you like to be added

I would like to have metadata attached to container definitions that are created by this orb in the form of aws tags. Implementation of tagging a resource can be done during its creation or after the fact.

During creation:
register-task-definition accepts a --tags argument.

After the fact:
with the tag-resource api

Either or both would be nice to be supported by this orb.

Why is this needed

This is helpful for release pipeline tracking, debugging and monitoring. Some tag that are useful could be:
'Approver' <- who approved the circleci pipeline
'GitSha' <- what code is part of this deploy.
'CreatedBy' <- tag that indicated resource created by "circle" for example.

I am sure there are other use cases.

@dgeorges dgeorges added the enhancement New feature or request label Feb 9, 2021
@dgeorges
Copy link
Contributor Author

dgeorges commented Apr 5, 2021

HI,

I would like to take this issue on. I am not sure how approval works, so before I get started I just wanted to describe my planned change for review.

The update-service command will take a new parameter named task-definition-tags which will be a string in the format "key=,value=,.... If specified the task-definition will be tagged with the given tags using the aws ecs tag-resource api.

@brivu
Copy link
Contributor

brivu commented May 13, 2022

This has been merged in #127

@brivu brivu closed this as completed May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants