Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement deployment circuit breaker with rollback for deployment controller of type CODE_DEPLOY #134

Closed
vatima2016 opened this issue May 19, 2021 · 0 comments · Fixed by #158
Assignees

Comments

@vatima2016
Copy link

Describe Request:

Implement deployment circuit breaker with rollback for deployment controller of type CODE_DEPLOY.

Behavior now:
If a task can not reach healthy state, for example because of defect configuration, the aws-ecs/update-service command is terminated after verification-timeout (defaults to 10 minutes).

But the initiated CodeDeploy deployment is running until it times out in the Install lifecycle phase (defaults to 60 minutes).

Desired behavior:
The Orb should rollback CodeDeploy deployment in status InProgress if according Circle CI verification times out on verification-timeout

The Orb knows DEPLOYMENT_ID of the running deployment, so for example if rollback is desired run the following command:

aws deploy stop-deployment --deployment-id $DEPLOYMENT_ID --auto-rollback-enabled

Supporting Documentation Links:

https://awscli.amazonaws.com/v2/documentation/api/latest/reference/deploy/stop-deployment.html

@vatima2016 vatima2016 changed the title Implement deployment circuit breaker with rollback for deployment controller of type CODE_DEPLOY feat: Implement deployment circuit breaker with rollback for deployment controller of type CODE_DEPLOY May 19, 2021
@brivu brivu linked a pull request May 21, 2022 that will close this issue
@brivu brivu self-assigned this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants