Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No defaults for launch type on consumption of run-task #87

Closed
alekhrycaiko opened this issue Dec 18, 2019 · 2 comments
Closed

No defaults for launch type on consumption of run-task #87

alekhrycaiko opened this issue Dec 18, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@alekhrycaiko
Copy link
Contributor

What would you like to be added

On ecs run-task, I'd like to have a launch-type configuration that has no default values.

Currently the ECS run-task CLI doesn't require this launch-type parameter by default. However, the orb implementation requires this, and defaults to a Fargate value - which doesn't make sense for users who use EC2 launch types.

Why is this needed

For users who use launch-type of EC2, the current default value creates implementation friction - as the launch-type needs to be overridden. Default values being Fargate here will probably cause some errors for future users that don't want their tasks run under Fargate launch type.

@alekhrycaiko alekhrycaiko added the enhancement New feature or request label Dec 18, 2019
@alekhrycaiko
Copy link
Contributor Author

I have a similar dilemma with the awsvpc setting being true. In my circumstances, I would prefer to not have this default to true; and would ideally like to set this manually if I were actually using this setting.

@lokst
Copy link
Contributor

lokst commented Dec 19, 2019

Thanks for reporting this, we'll look into revising the defaults. In the meantime, there is an example of using run-task for EC2 launch types on https://circleci.com/orbs/registry/orb/circleci/aws-ecs#usage-run-task-ec2

@brivu brivu assigned brivu and unassigned lokst Jun 9, 2022
@brivu brivu closed this as completed Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants