Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkForUpdates should not output to stdout #796

Open
brandon-leapyear opened this issue Oct 7, 2022 · 0 comments
Open

checkForUpdates should not output to stdout #796

brandon-leapyear opened this issue Oct 7, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@brandon-leapyear
Copy link

Meta:

CircleCI CLI Version:
0.1.22150

Operating System:
MacOS

CircleCI CLI Diagnostic:


Current behavior:

Running any circleci command will run brew outdated to check if it's out of date. If brew outdated returns a non-zero exit code, circleci will dump an error message to stdout:

circleci-cli/cmd/root.go

Lines 215 to 218 in 37e2fc3

if err != nil {
fmt.Printf("Error checking for updates: %s\n", err)
fmt.Printf("Please contact support.\n\n")
}

So if you're running circleci config pack .circleci/ > .circleci/config.yml, config.yml will now contain the error message at the top.

Expected behavior:

The checkForUpdate messages should go to stderr

When did this begin / Was this previously working?:

We hadn't hit this codepath before.

Additional Information:

@brandon-leapyear brandon-leapyear added the bug Something isn't working label Oct 7, 2022
@abdelDriowya abdelDriowya self-assigned this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants