fix: go to definition for local orbs were not working #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesFaucherre
changed the title
JulesFaucherre
force-pushed
the
local-orbs-go-to-definition
branch
from
43d9397
to
a399d77
Compare
loderunner
approved these changes
Feb 6, 2024
JulesFaucherre
force-pushed
the
local-orbs-go-to-definition
branch
from
a399d77
to
42da6f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: None
Description
Go to definition in local orb, targeting other local orb elements was opening a folder instead of making the
Go to definition.Implementation details
The issue is actually that local orbs don't know which
yamlthey're coming from, so when asked for definition, they give<empty string>and the editor thus try opening the actual directory.To fix that, the
URIfield has been added to local orbs and it is passed when makingGo to definition.How to validate
Tests have been added but you can try this yourself by declaring a local orb with executor(s), command(s) and job(s). Have jobs use the local orb's executors or commands and try making go to definition on those to make sure it point to the right point.