Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include include-branch-in-cache-key in run and test jobs #161

Closed
matt-dalton opened this issue Sep 22, 2022 · 0 comments · Fixed by #234
Closed

Include include-branch-in-cache-key in run and test jobs #161

matt-dalton opened this issue Sep 22, 2022 · 0 comments · Fixed by #234
Assignees

Comments

@matt-dalton
Copy link

matt-dalton commented Sep 22, 2022

Describe Request:

I would like to use install-package's include-branch-in-cache-key: false across my jobs, because I don't think it makes sense to re-build my node_modules when starting a new branch if they haven't changed.

I run my test and type checks in separate node/test and node/run jobs. Because these don't have the same include-branch-in-cache-key setting, those jobs will always reinstall their dependencies on the first run on a new branch again.

Examples:

            - build_node # This job includes node/install-packages with include-branch-in-cache-key: false

            # I'd like to add include-branch-in-cache-key: false to these jobs too
            - node/test:
                  name: test
                  cache-version: *yarn_cache_version
                  run-command: test:ci
                  version: *tag
                  pkg-manager: yarn
                  test-results-for: jest
                  requires:
                      - build_node

            - node/run:
                  name: types
                  cache-version: *yarn_cache_version
                  pkg-manager: yarn
                  yarn-run: types
                  version: *tag
                  requires:
                      - build_node
                     

Supporting Documentation Links:

install-package
test/run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants