Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change install-packages include-branch-in-cache-key default to false #197

Open
blimmer opened this issue Oct 19, 2023 · 1 comment
Open

Comments

@blimmer
Copy link
Contributor

blimmer commented Oct 19, 2023

Describe Request:

Today, the cache key for install-packages includes the branch name in the cache key by default:

include-branch-in-cache-key:
type: boolean
default: true
description: >
If true, this cache bucket will only apply to jobs within the same branch.

This causes far more cache misses than necessary, IMO, especially because the lockfile hash is already included in the key.

I propose we change the default from true to false in the next major release. This will significantly improve user experience by reducing runtimes.

@ssunday
Copy link

ssunday commented Nov 6, 2023

Very much agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants