Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "image-name" parameter to job to allow setting image URL #64

Open
nmiyake opened this issue Oct 21, 2024 · 1 comment · May be fixed by #65
Open

Add "image-name" parameter to job to allow setting image URL #64

nmiyake opened this issue Oct 21, 2024 · 1 comment · May be fixed by #65

Comments

@nmiyake
Copy link

nmiyake commented Oct 21, 2024

Describe Request:

Currently, the executor for the check job is hard-coded as the following:

docker:
  - image: cimg/base:<<parameters.image-tag>>

When using this job internally, we are running into an issue where we're hitting rate limiting on pulling the cimg/base image. We could resolve this by pulling a version of this image that we mirror internally, but are currently unable to do so because cimg/base is hard-coded.

The request is to add an image-name parameter analogous to image-tag that allows customizing the image that is used for the job. The default value would be cimg/base, which would preserve the current behavior for backcompat purposes.
@nmiyake
Copy link
Author

nmiyake commented Oct 21, 2024

Somewhat related to #56 and #58

@nmiyake nmiyake mentioned this issue Oct 21, 2024
Open
nmiyake added a commit to nmiyake/shellcheck-orb that referenced this issue Oct 21, 2024
@nmiyake
Add "image-name" as a parameter for the "check" job
bf036ca 
Allows the Docker image used by the "check" job to be customized.
The default value is "cimg/base", which preserves backwards
compatibility for current callers.

Fixes CircleCI-Public#64
@nmiyake nmiyake linked a pull request Oct 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "image-name" as a parameter for the "check" job nmiyake/shellcheck-orb
1 participant
@nmiyake