Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar image is not compressed in onboarding #533

Open
llunaCreixent opened this issue Nov 5, 2022 · 1 comment
Open

Avatar image is not compressed in onboarding #533

llunaCreixent opened this issue Nov 5, 2022 · 1 comment
Assignees

Comments

@llunaCreixent
Copy link
Member

Describe the bug
In the onboarding process I couldn't upload an image and an error was reported. However after validation my account I was able to upload the same image when editing my profile.

To Reproduce
Steps to reproduce the behavior:

  1. Sign up in circles.garden
  2. Try to upload an big image from your fallery
  3. See error
  4. Click "i'll do it later"
  5. Get three trusts
  6. Deploy account
  7. Go to edit profile
  8. Select the same image from the gallery
  9. No error

Expected behavior
I expected the app compresses my image in the onboarding process

@llunaCreixent llunaCreixent added the bug 💥 Something isn't working label Nov 5, 2022
@louilinn
Copy link
Collaborator

This is because the Onboarding.js uses component AvatarUploader.js and EditProfile.js does not. We have duplicated functionality. When EditProfile was implemented, the AvatarUploader component was not used / updated.

The functionality in EditProfile.js (uploadPhoto function) should be moved to Avatar Uploader to replace the approach there.
AvatarUploader should then be used in both Onboarding.js and EditProfile.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants