Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in references page #305

Closed
ShubhankarKG opened this issue May 18, 2020 · 3 comments · Fixed by #306
Closed

Typo in references page #305

ShubhankarKG opened this issue May 18, 2020 · 3 comments · Fixed by #306

Comments

@ShubhankarKG
Copy link
Contributor

Describe the bug

The reference page has a link named https://electronicsforu.com/resources/learn-electronics/flip-flop-rs-jk-t-dputting which is a typo error. This leads to a 404 on going to the site specified.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'https://learn.circuitverse.org'
  2. Click on 'references'
  3. Scroll down to 'point 4'
  4. Click the link to see error.

Expected behavior

A new page that opens up a specified reference resource.

Screenshots

Screenshot from 2020-05-18 09-30-53
Screenshot from 2020-05-18 09-31-06

Desktop (please complete the following information):

  • OS: Ubuntu 18.04
  • Browser: Chrome
  • Version [e.g. 22]

Additional context

Two other things to note:

  1. The Reference.md begins with a capital R. This is inconsistent with all files. Need to rename that.
  2. The target: _blank without the use of rel="noopener noreferrer" is considered bad practice with respect to performance and security issues. Need to add that as well.
@Shivansh2407
Copy link
Member

Are you working with this issue @ShubhankarKG ?

@ShubhankarKG
Copy link
Contributor Author

Yes. Will send a PR soon

@Shivansh2407
Copy link
Member

Sure. The correct Link is : https://www.electronicsforu.com/resources/learn-electronics/flip-flop-rs-jk-t-d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants