Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ib): inline HTML tags and support for sub, sup tags #116

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

manjotsidhu
Copy link
Member

@manjotsidhu manjotsidhu commented Jul 25, 2021

Fixes #103

Describe the changes you have made in this PR -

  • Added Inline HTML Syntax
  • Added Subscript and Superscript markdown builder

Note: To be merged after #115

@manjotsidhu manjotsidhu added the enhancement New feature or request label Jul 25, 2021
@manjotsidhu manjotsidhu requested a review from Nitish145 July 25, 2021 06:31
@manjotsidhu manjotsidhu self-assigned this Jul 25, 2021
@coveralls
Copy link

coveralls commented Jul 25, 2021

Pull Request Test Coverage Report for Build 1066049806

  • 9 of 27 (33.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 74.487%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/utils/unicode_map.dart 0 1 0.0%
lib/ui/views/ib/syntaxes/ib_inline_html_syntax.dart 1 6 16.67%
lib/ui/views/ib/builders/ib_subscript_builder.dart 0 6 0.0%
lib/ui/views/ib/builders/ib_superscript_builder.dart 0 6 0.0%
Totals Coverage Status
Change from base Build 1066008628: -0.2%
Covered Lines: 3886
Relevant Lines: 5217

💛 - Coveralls

Signed-off-by: Manjot Sidhu <manjot.techie@gmail.com>
@commit-lint
Copy link

commit-lint bot commented Jul 26, 2021

Bug Fixes

  • ib: Inline HTML tags and support for sub, sup tags (a0d6b77)

Contributors

manjotsidhu

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@manjotsidhu manjotsidhu changed the title fix(ib): Fix Inline HTML tags and add support for sub, sup. fix(ib): inline HTML tags and support for sub, sup tags Jul 26, 2021
@Nitish145 Nitish145 merged commit cbc9eb9 into master Jul 27, 2021
@Nitish145 Nitish145 deleted the ib-sub-super branch July 27, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Interactive Book] Fix inline HTML tags like sup and sub
3 participants