Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ib): scroll to index links in table of contents #123

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

manjotsidhu
Copy link
Member

@manjotsidhu manjotsidhu commented Aug 5, 2021

Ref #104

Describe the changes you have made in this PR -

  • Added package scroll_to_index
  • Added custom headings builder having auto scroll tags by index
  • Added action onTap headings in Table of Contents to scroll to the specific action

Screenshots of the changes (If any) -

video_2021-08-05_13-09-30.mp4

@manjotsidhu manjotsidhu added the enhancement New feature or request label Aug 5, 2021
@manjotsidhu manjotsidhu requested a review from Nitish145 August 5, 2021 07:41
@manjotsidhu manjotsidhu self-assigned this Aug 5, 2021
@commit-lint
Copy link

commit-lint bot commented Aug 5, 2021

Bug Fixes

  • ib: bug fixes and misc improvements (9fc1fb5)

Features

  • ib: scroll to index links in table of contents (1589ae1)

Contributors

manjotsidhu

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@coveralls
Copy link

coveralls commented Aug 5, 2021

Pull Request Test Coverage Report for Build 1111754165

  • 25 of 42 (59.52%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 74.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/ib/builders/ib_headings_builder.dart 10 11 90.91%
lib/services/ib_engine_service.dart 9 15 60.0%
lib/ui/views/ib/ib_page_view.dart 4 14 28.57%
Files with Coverage Reduction New Missed Lines %
lib/ui/views/ib/ib_page_view.dart 1 63.08%
Totals Coverage Status
Change from base Build 1107173516: -0.02%
Covered Lines: 3908
Relevant Lines: 5271

💛 - Coveralls

lib/ui/views/ib/ib_page_view.dart Outdated Show resolved Hide resolved
Signed-off-by: Manjot Sidhu <manjot.techie@gmail.com>
@Nitish145 Nitish145 merged commit 9e9287f into master Aug 10, 2021
@Nitish145 Nitish145 deleted the ib-scroll-to-index branch August 10, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants