fix(ib): introduce vertical padding in headings #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manjot Sidhu <manjot.techie@gmail.com>
Pull Request Test Coverage Report for Build 1122568378
💛 - Coveralls |
Nitish145
approved these changes
Aug 12, 2021
| @@ -22,7 +22,7 @@ class IbMdTagSyntax extends md.BlockSyntax { | |||
| return md.Element.text('h5', text); | |||
| } | |||
|
|
|||
| // (TODO) Fix Pop Quizes | |||
| // Pop Quizzes | |||
There was a problem hiding this comment.
I assume the Pop Quizzes worked fine already, but because changing the comment is such a small change, you added this in this PR only, right?
There was a problem hiding this comment.
Pop Quizzes are working fine but somehow I forgot to remove TODO and while checking code, I found this outdated comment and updated it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR -
Added vertical paddings to Headings (h1-h6)
Screenshots of the changes (If any) -
