Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy Loading feature added #76

Closed
wants to merge 2 commits into from

Conversation

PaRaDoX50
Copy link
Contributor

@PaRaDoX50 PaRaDoX50 commented Feb 9, 2021

Fixes #74

Changes I made:

Attached a Scroll Controller to the SingleChildScrollView and added a listener to it which loads data when a user reaches to certain scroll extent. Also added a CircularProgessIndicator which appears when loading more circuits.
Preview:

after.mp4

@manjotsidhu
Copy link
Member

@PaRaDoX50 I think the current implementation loads new circuits on scroll ?

@PaRaDoX50
Copy link
Contributor Author

@PaRaDoX50 I think the current implementation loads new circuits on scroll ?

This implementation loads new circuits when the user scrolls (maxScroll - 200) pixels.

@manjotsidhu
Copy link
Member

@PaRaDoX50 I think the current implementation loads new circuits on scroll ?

This implementation loads new circuits when the user scrolls (maxScroll - 200) pixels.

I think it should load only when the scroll is reached to almost near the bottom.

@PaRaDoX50
Copy link
Contributor Author

@PaRaDoX50 I think the current implementation loads new circuits on scroll ?

This implementation loads new circuits when the user scrolls (maxScroll - 200) pixels.

I think it should load only when the scroll is reached to almost near the bottom.

In my opinion, 200 is a optimum number and saves user's time since loading 5 more items is not big of a network call. But still if we want to adjust it, we will only have to change a variable named "delta".

@manjotsidhu
Copy link
Member

@PaRaDoX50 The UI Tests are failing can you check it.

@manjotsidhu
Copy link
Member

closing since inactive, please submit another PR if you want to work further.

@manjotsidhu manjotsidhu closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Implementing Lazy Loading(Scroll to load) for FeaturedProjectView
2 participants