Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev python3 #25

Open
wants to merge 1 commit into
base: dev-python3
Choose a base branch
from
Open

Dev python3 #25

wants to merge 1 commit into from

Conversation

paxcut
Copy link

@paxcut paxcut commented Feb 19, 2021

changes to fix #24

@paxcut paxcut mentioned this pull request Feb 19, 2021
Open
@paxcut paxcut changed the base branch from master to dev-python3 February 21, 2021 09:10
IdanH101
IdanH101 approved these changes Oct 14, 2021
View reviewed changes
Copy link

@IdanH101 IdanH101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve that this change in fact solves the timeout problem after analysing in windows 10, IDA pro 7.5

@IdanH101 IdanH101 mentioned this pull request Oct 14, 2021
Closed
Ivanmatthew
Ivanmatthew suggested changes Sep 18, 2023
View reviewed changes
ghida_plugin/lib.py
if os.name != 'posix':
(out, err) = p.communicate()
out = out.decode('utf-8')
err = err.decode('utf-8')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err may sometimes be None, you can fix this with

if os.name != 'posix':
    (out, err) = p.communicate()
    if out is not None:
        out = out.decode('utf-8')
    #else:
    #    print("GhIDA:: [DEBUG] out from process is None")
    if err is not None:
        err = err.decode('utf-8')
    #else:
    #    print("GhIDA:: [DEBUG] err from process is None")

@Ivanmatthew
Copy link

Ivanmatthew commented Sep 18, 2023 •
edited
Loading

Your fix also works with python2 version. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivanmatthew Ivanmatthew Ivanmatthew requested changes

@IdanH101 IdanH101 IdanH101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ghidra headless analysis failed
3 participants
@paxcut @Ivanmatthew @IdanH101