[minor_change] Add read-only pcTag, scope and segment attributes to aci_bridge_domain resource and datasource and add scope to aci_endpoint_security_group and aci_application_epg resources and datasources (DCNE-257) #1302
Conversation
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
akinross
force-pushed
the
read_only_attribute_updates
branch
2 times, most recently
from
e73c5d6 to
d523689
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1302 +/- ##
==========================================
+ Coverage 85.45% 85.49% +0.04%
==========================================
Files 125 125
Lines 70689 70986 +297
==========================================
+ Hits 60409 60693 +284
- Misses 8324 8337 +13
Partials 1956 1956 ☔ View full report in Codecov by Sentry. |
| @@ -227,6 +227,10 @@ All examples for the Bridge Domain resource can be found in the [examples](https | |||
| * `name_alias` (nameAlias) - (string) The name alias of the Bridge Domain object. | |||
| * `owner_key` (ownerKey) - (string) The key for enabling clients to own their data for entity correlation. | |||
| * `owner_tag` (ownerTag) - (string) A tag for enabling clients to add their own data. For example, to indicate who created this object. | |||
| * `pc_tag` (pcTag) - (string) The classification tag used for policy enforcement and zoning. | |||
| * `scope` (scope) - (string) The L3 scope ID of the Bridge Domain object. | |||
| - Default: `0` | |||
There was a problem hiding this comment.
Shall we skip specifying a Default for this, if it is a Read Only property?
There was a problem hiding this comment.
Yes but it should also not be under optional. We already discussed this issue. Created a new issue to track this: #1303
gen/templates/resource.go.tmpl
Outdated
| @@ -1412,14 +1412,9 @@ func (r *{{.ResourceClassName}}Resource) Schema(ctx context.Context, req resourc | |||
| stringplanmodifier.UseStateForUnknown(), | |||
| }, | |||
| {{- end}} | |||
| {{- if or .ValidValues $.HasReadOnlyProperties}} | |||
| {{- if or .ValidValues}} | |||
There was a problem hiding this comment.
Wouldn't this change bring the "update in place" issue we spoke about earlier? or was this fixed in Terraform side?
There was a problem hiding this comment.
I do not see this issues so not sure this is the same situation you had.
The “MakeSingleNestedAttributeRequiredAttributesNotProvidedValidator("{{.ResourceName}}", []string{"{{listToString .RequiredPropertiesNames}}"}),” part already handles the required setting in single nested attributes to allow for {} to be passed in when there are required attributes so the MakeStringRequired should not be used in the validator.
akinross
force-pushed
the
read_only_attribute_updates
branch
from
d523689 to
85a8767
Compare
akinross
force-pushed
the
read_only_attribute_updates
branch
from
85a8767 to
f93e021
Compare
…nd all in testvars
…ci_bridge_domain resource and datasource and add scope to aci_endpoint_security_group and aci_application_epg resources and datasources
akinross
force-pushed
the
read_only_attribute_updates
branch
from
f93e021 to
8f7cd5c
Compare
…e nested attributes
No description provided.