Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old Town policy shouldn't affect public transport #371

Closed
originalfoo opened this issue Jun 9, 2019 · 10 comments · Fixed by #1618
Closed

Old Town policy shouldn't affect public transport #371

originalfoo opened this issue Jun 9, 2019 · 10 comments · Fixed by #1618
Assignees
Labels
BUG Defect detected COMPATIBILITY Mod (in)compatibility / checker confirmed Represents confirmed issue or bug EXTERNAL Mod conflict or other external factor in-progress The problem is being solved currently PATHFINDER Pathfinding tweaks or issues Usability Make mod easier to use VEHICLE RESTRICTIONS Feature: Vehicle restrictions
Milestone

Comments

@originalfoo
Copy link
Member

originalfoo commented Jun 9, 2019

As per recent Discord discussion, the Old Town city & district policy affects taxis.

This seems strange, to me at least, as I would actually expect a result of that policy to be forcing outsiders to use taxis to access and leave the area.

So, IMO, taxis should ignore the Old Town policy. We could test that functionality on the LABS version to get feedback from players (eg. should it be setting on Policies tab in mod options, or setting in global xml, or is it what people expect by default)?

@originalfoo originalfoo added enhancement Improve existing feature Usability Make mod easier to use labels Jun 9, 2019
@originalfoo
Copy link
Member Author

From Discord:

The problem is caused by the old town policies you have set up. Taxis are also affected by those. When costs become too high path-finding fails

We could make taxis ignore car bans but that might not be desirable by other players

For example, this taxi (blue circle) needs to leave the city area but you blocked u-turns at the junction (yellow circle). It could take a detour (red line) but path-finding costs explode because old town policy is active

unknown

That's precisely the situation where taxis and PT would excel.

@VictorPhilipp
Copy link
Collaborator

Also applicable for busses

@VictorPhilipp VictorPhilipp changed the title Old Town policy shouldn't affect taxis Old Town policy shouldn't affect public transport Jun 10, 2019
@VictorPhilipp VictorPhilipp self-assigned this Jun 10, 2019
@VictorPhilipp VictorPhilipp added this to the 11.0 milestone Jun 10, 2019
@VictorPhilipp
Copy link
Collaborator

VictorPhilipp commented Jun 10, 2019

I set it to version 11.0 so that we can try this in labs first.
If we add a new property to the global configuration or in-game options we must remember to create a corresponding field for stable (10.x) too

@originalfoo
Copy link
Member Author

originalfoo commented Jul 31, 2019

Old town should also not affect service vehicles.

It's possible the policy is affecting hearses in particular (just seen a Steam user mention that).

@originalfoo originalfoo added BUG Defect detected confirmed Represents confirmed issue or bug EXTERNAL Mod conflict or other external factor VEHICLE RESTRICTIONS Feature: Vehicle restrictions PATHFINDER Pathfinding tweaks or issues labels Aug 12, 2019
@originalfoo originalfoo added the COMPATIBILITY Mod (in)compatibility / checker label Aug 13, 2019
@originalfoo originalfoo added high priority Affects lots of users and removed enhancement Improve existing feature labels Aug 31, 2019
@krzychu124
Copy link
Member

Is it bug in our code or it just need some sort of pathfinding tweaks?

@originalfoo
Copy link
Member Author

I think it's bug in TM:PE pathfinder or AIs - the old town policy seems to block public transport, which it should not do.

As user defines most PT routes, they can simply choose not to put routes through an area if they don't want PT in that area.

However, an option to enable taxis in Old Town areas might be beneficial, something like:

[x] Allow taxis to enter districts with Old Town policy ?

@krzychu124
Copy link
Member

That's strange because I've made big district with this policy selected and everything worked just like on vanilla
Game code looks exactly the same, but it is possible that vanilla penalty is too big when pathfinder applies it along with our custom values.
I will test it again on new savegame

@originalfoo originalfoo modified the milestones: 11.2, 11.3 Mar 28, 2020
@krzychu124
Copy link
Member

@aubergine10 Is it still valid issue?

@originalfoo
Copy link
Member Author

originalfoo commented Feb 28, 2022

I'm not sure - I very rarely use that Old Town policy so not sure what effect it has on PT vehicles such as taxis, bus, etc.

Is your vehicle spawner thing able to do taxis, hearses, etc?

@krzychu124
Copy link
Member

Not yet, but I can spawn ambulances/firetrucks/police vehicles so extending to more service vehicles won't be a problem, can work on support probably at the weekend. I want to finish Airports DLC support thing first, since current work-in-progress version passed all my experiments - ready for cleanup.

@krzychu124 krzychu124 removed the high priority Affects lots of users label Jun 22, 2022
@krzychu124 krzychu124 self-assigned this Jun 23, 2022
@krzychu124 krzychu124 added the in-progress The problem is being solved currently label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected COMPATIBILITY Mod (in)compatibility / checker confirmed Represents confirmed issue or bug EXTERNAL Mod conflict or other external factor in-progress The problem is being solved currently PATHFINDER Pathfinding tweaks or issues Usability Make mod easier to use VEHICLE RESTRICTIONS Feature: Vehicle restrictions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants