Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Pedestrian Tool #40

Open
originalfoo opened this issue Feb 8, 2019 · 5 comments
Open

UI: Pedestrian Tool #40

originalfoo opened this issue Feb 8, 2019 · 5 comments
Labels
JUNCTION RESTRICTIONS Feature: Junction restrictions Pedestiran Crossing UI User interface updates

Comments

@originalfoo
Copy link
Member

originalfoo commented Feb 8, 2019

As per #38, the feature to toggle pedestrian crossings would be moved to it's own tool on the toolbar. This is primarily to reduce UI overload on the Junction Policies tool, but also to create room for some future functionality additions.

The tool serves two main purposes:

  1. Toggle existing pedestrian crossings - at junctions and at transitions between road types
    • Left-clicking an icon (or even the crossing itself?) toggles it
    • Ideally removing/updating decals, as applicable
  2. Add new crossings - at normal nodes between two segments
    • Left-clicking a node adds the crossing, and subsequent left click removes it
    • Similar to: Crossings mod
    • Should I create separate issue for this element, as it would be new feature?

At a later date, I suspect this tool would be extended to create #14 (virtual junctions), maybe by right-clicking or Ctrl+clicking a node?

The tool is essentially about pedestrian features, so I think adding the virtual junctions stuff (which is mostly about pedestrian features anyway) at a later date is in keeping with the concept of the tool.

@originalfoo
Copy link
Member Author

Toggle existing crossings

The current UI (in junction restrictions) is somewhat clunky, with a big icon floating above the map.

IMO it would be nicer if I could interact with crossings themselves.

To achieve this, an outline (like #33, lane outline, but for crossings) would be drawn around the crossing or just at the end of the segment on which the crossing exists. The user clicks in the outline to toggle the crossing.

The toggle crossing feature should also work with crossings at road-type changes and any crossings manually added at nodes by the user.

@originalfoo
Copy link
Member Author

originalfoo commented Feb 8, 2019

Add new crossings

With tool active:

  • User clicks a normal node = a crossing appears
    • Not sure which segment gets the crossing... maybe they click a segment, and it finds nearest node and adds crossing next to that?
  • That crossing is then treated like crossings that appear where different road types meet.
    • It gets the outline and subsequent left-clicks toggle it on and off

Potentially, these 'user created' crossings could be deleted too, maybe with right click in the crossing outline?

Source code for existing Crossings mod: https://github.com/bernardd/Crossings

@originalfoo
Copy link
Member Author

Ideally the tool would handle things like...

Some roads don't have crossing decals; this should be no issue as the UI will be drawing an outline around where the crossing would be (or, ideally, where it is, in the case of roads that do provide crossing decals).

Some roads have things like bevelled/tactile pavement (Urbanists' roads) or road studs (UK Roads Revived).

@originalfoo originalfoo changed the title UI: Crossings tool UI: Pedestrian Crossings tool Feb 8, 2019
@originalfoo
Copy link
Member Author

Eraser tool

As per #38, there will be an eraser tool on the toolbar.

This needs some ponderance; user might expect eraser to 'erase the crossing' (as in disable it) rather than delete or reset it.

While the Pedestrian Crossings tool is active, user can click the Eraser tool. Then:

  • Click a crossing to reset it to game default
    • If it was manually added, it is removed
    • Otherwise it returns to normal, active crossing

@originalfoo originalfoo changed the title UI: Pedestrian Crossings tool UI: Pedestrian Tool Feb 8, 2019
@originalfoo originalfoo added this to the UI improvements milestone Feb 9, 2019
@VictorPhilipp VictorPhilipp added the UI User interface updates label Mar 14, 2019
@originalfoo
Copy link
Member Author

Boformer thinks he may have a way to hide crossing decal per segment, see #27 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JUNCTION RESTRICTIONS Feature: Junction restrictions Pedestiran Crossing UI User interface updates
Projects
None yet
Development

No branches or pull requests

3 participants