Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot normally get using game language in 11.0 Third-party local translation. #533

Closed
TianQiBuTian opened this issue Oct 19, 2019 · 10 comments · Fixed by #534
Closed

Cannot normally get using game language in 11.0 Third-party local translation. #533

TianQiBuTian opened this issue Oct 19, 2019 · 10 comments · Fixed by #534
Labels
11 ALPHA TM:PE v11 alpha edition EXTERNAL Mod conflict or other external factor Localisation Localised text and features
Milestone

Comments

@TianQiBuTian
Copy link
Contributor

In 11.0 alpha version, TM:PE Cannot normally get using game language in using Third-party local translation mods.

(e.g.: https://steamcommunity.com/sharedfiles/filedetails/?id=812789818)

But can normally in STABLE(10.20) and LABS(10.21.1).

Screenshots:

In STABLE(10.20):
20191019162623_1

In LABS(10.21.1):
20191019155632_1

In Alpha(11.0):
20191019153845_1

Also, please review my Simplified Chinese in Crowdin. Because some translation is not correct in 11.0 version.

@TianQiBuTian TianQiBuTian added BUG Defect detected triage Awaiting issue categorisation labels Oct 19, 2019
@originalfoo
Copy link
Member

@originalfoo originalfoo added 11 ALPHA TM:PE v11 alpha edition Localisation Localised text and features and removed BUG Defect detected triage Awaiting issue categorisation labels Oct 19, 2019
@TianQiBuTian
Copy link
Contributor Author

Yea. But this is choose same as "Game language", and using local translation mods. It will only display the code.
This bug doesn't appear in STABLE and LABS versions. Only 11.0 alpha had this bug.

@originalfoo
Copy link
Member

originalfoo commented Oct 19, 2019

I've just tested all the languages in TM:PE and they all work as expected.

The bug is in those translation mods, not TM:PE. The authors of the external translation mods will have to update their mods.

@originalfoo originalfoo added EXTERNAL Mod conflict or other external factor out of scope Not applicable to TM:PE or should be separate mod labels Oct 19, 2019
@originalfoo
Copy link
Member

For reference, here are the changes that were made to TM:PE when we moved to new translation system:

https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/pull/509/files

@TianQiBuTian
Copy link
Contributor Author

TianQiBuTian commented Oct 19, 2019

I think this bug isn't caused by translation mods, because using translation mods in STABLE and LABS version don't had this bug, only 11.0 alpha version had this bug.
Maybe is new translation system doesn't get/load those Third-party translation mods. (idk)

@krzychu124 krzychu124 removed the out of scope Not applicable to TM:PE or should be separate mod label Oct 19, 2019
@originalfoo
Copy link
Member

I don't think the older versions loaded anything from the translation mods either. The translation mods must be altering TM:PE somehow and seeing as we've altered the translation system those mods are breaking.

Is there any reason the translations aren't just added directly to TM:PE? We can add local/regional dialects, as many languages as desired...

Also, I think @krzychu124 is investigating what those translation mods do to see how they work.

@krzychu124
Copy link
Member

Correction of game language name was missing(in case of using custom language file).
PR #534 should fix the issue.

@originalfoo
Copy link
Member

It would be better if those mods specified correct language - otherwise they'll break any other mod that has inbuilt localisation (eg. @klyte45 mods).

@krzychu124
Copy link
Member

Mentioned mod is creating new locale file with key zh-cn,
CO created locale exporter for modders to help creating new locale files.
Game is loading all files with .locale extension from Locale folder so any file which pass validation stage is registered and available in-game "out of the box".

@originalfoo
Copy link
Member

I'll push an update to the v11 workshop page later today.

@originalfoo originalfoo added this to the 11.0 milestone Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 ALPHA TM:PE v11 alpha edition EXTERNAL Mod conflict or other external factor Localisation Localised text and features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants