Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --continuelastsave launch option skips mod checker panel #697

Closed
originalfoo opened this issue Feb 12, 2020 · 4 comments · Fixed by #1310 · May be fixed by #699
Closed

The --continuelastsave launch option skips mod checker panel #697

originalfoo opened this issue Feb 12, 2020 · 4 comments · Fixed by #1310 · May be fixed by #699
Assignees
Labels
Annoyance Not a bug, but just as annoying COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor help wanted Seeking assistance high priority Affects lots of users in-progress The problem is being solved currently
Milestone

Comments

@originalfoo
Copy link
Member

Since new launcher, the --continuelastsave launch option (what happens when user clicks "Resume" on the launcher app) makes game automatically reload last save.

If TM:PE finds mod incompatibility, it shows the purple warning dialog expecting main menu to remain in background. However, --continuelastsave just closes all that down and dives in to game. From user perspective, a purple panel flickers up for less than a second then disspaears again as their last save starts to load.

So we need some way to disable --continuelastsave if mod incompatibility is found.

I'm not entirely sure how to do that. I suspect by the time we get round to displaying the "incompatibel mods found" panel, the game has already kicked in loading of last savegame.

@originalfoo originalfoo added Annoyance Not a bug, but just as annoying high priority Affects lots of users EXTERNAL Mod conflict or other external factor COMPATIBILITY Mod (in)compatibility / checker labels Feb 12, 2020
@originalfoo originalfoo added this to the 11.1.1 milestone Feb 12, 2020
@originalfoo
Copy link
Member Author

LauncherLoginData.instance.m_continue

@originalfoo
Copy link
Member Author

if (LauncherLoginData.instance.m_continue)
	{
		LauncherLoginData.instance.m_continue = false;
		Invoke("AutoContinue", 2.5f);
		m_BackgroundImage.zOrder = int.MaxValue;
	}
	else
	{
		m_BackgroundImage.zOrder = 0;
	}

@originalfoo originalfoo self-assigned this Feb 12, 2020
@originalfoo originalfoo added in-progress The problem is being solved currently help wanted Seeking assistance labels Feb 12, 2020
@originalfoo
Copy link
Member Author

At the end of compatibility checking, if no problems found (ie. no need to exit to desktop), I need to invoke a method on the main menu but not sure how to get hold of the main menu instance...

This is the method I want to invoke:

MainMenu.Invoke("AutoContinue", 2.5f);

Any ideas? @krzychu124

@krzychu124
Copy link
Member

Isn't main menu instance accessible from UIView library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Annoyance Not a bug, but just as annoying COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor help wanted Seeking assistance high priority Affects lots of users in-progress The problem is being solved currently
Projects
None yet
2 participants