Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lane arrows when junction has 2 segments. #873

Open
kianzarrin opened this issue Apr 28, 2020 · 9 comments
Open

Remove lane arrows when junction has 2 segments. #873

kianzarrin opened this issue Apr 28, 2020 · 9 comments
Labels
feature A new distinct feature triage Awaiting issue categorisation

Comments

@kianzarrin
Copy link
Collaborator

kianzarrin commented Apr 28, 2020

There is no reason to have forward lane arrows in the node bellow
Screenshot (938)

for now I can use TMPE lane arrow tool to remove all lane arrows. what are the side effects of that? does that cause vehicles to be able to do UTurn? if not maybe we can automatically remove all flags as a solution.

EDIT: Lane arrow tool should also not be able to select such lanes.

@kianzarrin kianzarrin added feature A new distinct feature triage Awaiting issue categorisation labels Apr 28, 2020
@kianzarrin
Copy link
Collaborator Author

kianzarrin commented Apr 28, 2020

BTW can vehicles do uturn if there is no left lane arrow?
Screenshot (940)
Screenshot (939)

EDIT: we probably need a special prop for uturn in future but for now at the very least, there should be a left turn prop for uturn.

@kianzarrin kianzarrin changed the title Remove lane arrows when junction has to road segments. Remove lane arrows when junction has 2 segments. Apr 28, 2020
@chameleon-tbn
Copy link
Contributor

chameleon-tbn commented Apr 28, 2020

There is no reason to have forward lane arrows in the node bellow

for now I can use TMPE lane arrow tool to remove all lane arrows. what are the side effects of that? does that cause vehicles to be able to do UTurn? if not maybe we can automatically remove all flags as a solution.

EDIT: Lane arrow tool should also not be able to select such lanes.

In my opinion these lanes should be handled as going just straight ahead and no u-turn should be possible.

@chameleon-tbn
Copy link
Contributor

BTW can vehicles do uturn if there is no left lane arrow?

EDIT: we probably need a special prop for uturn in future but for now at the very least, there should be a left turn prop for uturn.

In my opinion the u-turn symbol should ignore the straight ahead arrow. It would be nice to have a u-turn prop or decal.

It might be an option to have various combinations:

  • Straight ahead w/o u-turn = straight arrow (cars can only do straight ahed)
  • Straight ahead with u-turn = straight arrow and a u-turn prop (cars can go both directions)
  • Left with u-turn = u-turn arrow decal and handle it as a dedicated u-turn lane. (cars can only u-turn)

@originalfoo
Copy link
Member

originalfoo commented Apr 28, 2020

U-turn is a mess in TMPE, I think there's like 3 ways it's implemented:

  • lane connectors
  • lane arrows (possibly, haven't checked)
  • junction restriction u-turn sign

None of them are synced - for example if I allow u-turn in junction restrictions, lane connectors do not reflect that and vice versa. Really we should just have one way to do u-turns, and maybe it should factor in medians too?

@originalfoo
Copy link
Member

Also, if we start changing props we should also consider merging arrow for transition to segment with fewer lanes. There's a merging flag (which does seem get set based on quick scan of which flags were in use at a small city) but I've never seen an automatically placed merging arrow.

And, furthermore, if we go down the route of changing arrows, we should collab with asset creators to get sets of arrows for different countries.

@kianzarrin
Copy link
Collaborator Author

@aubergine10 I think we are getting distracted here (sorry my bad I started it!). the main subject is :
1- Remove lane arrow props when unnecessary.
2- what will happen if I remove all lane arrows with lane arrow tool? will it still work as normal?

@originalfoo
Copy link
Member

I don't know what will happen if none of the arrow flags are set. I think the way the game decides whether to show the arrows is based on segment node flags (eg. is it a junction/transition/etc) and suspect arrow flags are always being set.

Note also that if we unset all the arrow flags, what effect does that have on vanilla game? We have to factor in what happens if user removes TMPE - their game should ideally keep working as normal.

To hide arrows (which, btw, is a feature request that pops up occasionally - even the arrows at junction nodes) I suspect you might need to start digging in to the render code again similar to what you did for hiding crossings. Although hopefully for arrow props it will be much simpler task.

@originalfoo
Copy link
Member

Off-topic, but there are other places where TMPE tools are possibly appearing at wrong types of nodes: #364

@originalfoo
Copy link
Member

Tagging: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new distinct feature triage Awaiting issue categorisation
Projects
None yet
Development

No branches or pull requests

3 participants