Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove django-environ #864

Closed
brylie opened this issue Apr 26, 2021 · 0 comments · Fixed by #873
Closed

Remove django-environ #864

brylie opened this issue Apr 26, 2021 · 0 comments · Fixed by #873
Labels
code quality dependencies Pull requests that update a dependency file enhancement help wanted
Milestone
2.0

Comments

@brylie
Copy link
Member

brylie commented Apr 26, 2021

We currently load environment variables using django-environ in settings.py. However, django-environment only supports Django up to around version 2. Since we aim to use the latest Django LTS (version 3.2 #848) we should remove django-environ.

Remove django-environ and use os.getenv instead. Any code using environment variables should be allowed to have a None value for the environment variable, with sensible defaults.
@brylie brylie added enhancement help wanted code quality dependencies Pull requests that update a dependency file labels Apr 26, 2021
@brylie brylie added this to the 2.0 milestone Apr 26, 2021
@obafemiolorungbon obafemiolorungbon mentioned this issue May 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality dependencies Pull requests that update a dependency file enhancement help wanted
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Remove django environ obafemiolorungbon/OpenCiviWiki
1 participant
@brylie