Countdown issues on index (and misleading info)

[pnijjar]

This is mostly for @kingscott .

The sentence "Search for information about where to vote and who is running in your riding" is misleading. We do not provide information about where people should vote -- polling station info is done by Elections Canada, and we do not link there.

As for the counter: if it is past the day, then I suggest that the text reads: "The federal election was Oct 21" or "The election is over" or something. More importantly, the counter is wrong if people have Javascript disabled. In that case the counter reads "60 days", which is actively harmful. If people do not have Javascript then the counter should just not appear, in my opinion.

Instead of "Countdown to the federal election" I think the (non-Javascript) title should have the date in it: "The federal election is October 21, 2019". (I guess this is what we had before.) Then below that the counter can say something like "18 days left!".

[kingscott]

I'll tackle these this afternoon weekend, @pnijjar.

Just for context, I didn't change any of the copy regarding the search area, so that must've carried over from the last iteration of the voting site. I'll update that as well.

Yes, I was planning on updating that today as well. I was just getting it out the door last night. I think the pool of those not running JavaScript is relatively small and will effect only the smallest group. I can add in some measures to make sure only a static date shows. But if JavaScript is disabled, a good portion of the website won't function.

Sure, happy to update the main header on the main page 👍

[pnijjar]

The commit that changed the wording above the map was 41c92be , which was part of your PR to update the logo. But it does not really matter.

Designing for people without Javascript was one of the design goals of the site (because I use a browser that does not have Javascript). Everything on the site works except for the embedded map, as far as I know. Some of the visual effects go missing but all of the data (and I guess the CSS theming) remains.

[kingscott]

Oh, yes. I stand corrected, I was referencing the designs there.

Good to know; I wasn't aware that that was the case.

I have some family business to attend to and likely won't be able to look at this until the weekend, expect to see some PRs anytime between now and then.

[kingscott]

Also, Paul, what browser do you use? I'd be curious to install it and make sure to test it alongside any changes I make moving forward :)

[pnijjar]

w3m on Linux. It is a text-mode browser I use for quick lookups.  On Thursday, October 3, 2019, 04:35:05 p.m. ADT, Scott King <notifications@github.com> wrote: Also, Paul, what browser do you use? I'd be curious to install it and make sure to test it alongside any changes I make moving forward :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.