Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate -Wcomma #1968

Closed
nickdesaulniers opened this issue Dec 18, 2023 · 3 comments
Closed

evaluate -Wcomma #1968

nickdesaulniers opened this issue Dec 18, 2023 · 3 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@nickdesaulniers
Copy link
Member

existing issues need to be fixed first.

https://lore.kernel.org/all/20230630192825.GA2745548@dev-arch.thelio-3990X/

https://lore.kernel.org/llvm/20231218190055.GB2863043@dev-arch.thelio-3990X/

@nickdesaulniers nickdesaulniers added enhancement New feature or request good first issue Good for newcomers labels Dec 18, 2023
@JustinStitt
Copy link
Collaborator

Hi, is the usage of the comma operator just bad taste or is there a functional problem caused by some of its use scenarios?

@nathanchance
Copy link
Member

Little column A, little column B in my opinion. In particular, it can result in problems like #390 and https://lore.kernel.org/58466.1688074499@warthog.procyon.org.uk/.

@nickdesaulniers
Copy link
Member Author

Going to close this as wontfix (but feel free to reopen). The issues I looked at from x86 and arm defconfigs seem to be people avoiding the use of block statements (via comma operator) or as loop conditions (which possibly could have been statements within the loop), but none of the cases looked like bugs or anything worthwhile to address IMO.

@nickdesaulniers nickdesaulniers added wontfix This will not be worked on and removed good first issue Good for newcomers labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants