Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wsometimes-uninitialized in drivers/net/ethernet/broadcom/bnxt/bnxt.c #398

Closed
nathanchance opened this issue Feb 26, 2019 · 3 comments
Closed

-Wsometimes-uninitialized in drivers/net/ethernet/broadcom/bnxt/bnxt.c #398

nathanchance opened this issue Feb 26, 2019 · 3 comments
Assignees
@nathanchance
Labels
-Wsometimes-uninitialized [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.1 This bug was fixed in Linux 5.1

Comments

@nathanchance
Copy link
Member

Meta: #381

drivers/net/ethernet/broadcom/bnxt/bnxt.c:1606:6: error: variable 'len' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]

in bnxt_rx_pkt.
@nathanchance nathanchance added good first issue Good for newcomers [BUG] linux A bug that should be fixed in the mainline kernel. low priority This bug is not critical and not a priority -Wsometimes-uninitialized labels Feb 26, 2019
@nathanchance nathanchance self-assigned this Mar 8, 2019
@nathanchance nathanchance removed good first issue Good for newcomers low priority This bug is not critical and not a priority labels Mar 8, 2019
@nathanchance
Copy link
Member Author

Inquiry sent to the maintainers because I don't know if changing the goto is right or not: https://lore.kernel.org/lkml/20190308005735.GA4122@archlinux-ryzen/

@nathanchance
Copy link
Member Author

A patch for this has been submitted. At this time, every other -Wsometimes-uninitialized warning has been fixed in -next. Once this has hit, we can turn it on!

https://lore.kernel.org/netdev/1556245915-5430-7-git-send-email-michael.chan@broadcom.com/

@nathanchance nathanchance added the [PATCH] Submitted A patch has been submitted for review label Apr 26, 2019
@nathanchance
Copy link
Member Author

Merged into mainline: https://git.kernel.org/linus/0b397b17a4120cb80f7bf89eb30587b3dd9b0d1d

@nathanchance nathanchance added [FIXED][LINUX] 5.1 This bug was fixed in Linux 5.1 and removed [PATCH] Submitted A patch has been submitted for review labels May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wsometimes-uninitialized [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.1 This bug was fixed in Linux 5.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance