Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Add option for "--use-aapt2" when build with apktool #37

Closed
yfyau opened this issue Jun 30, 2020 · 3 comments
Closed

Add option for "--use-aapt2" when build with apktool #37

yfyau opened this issue Jun 30, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yfyau
Copy link

yfyau commented Jun 30, 2020

Is this feature request related to a problem?

Yes, I was facing an error when build the new apk. And I found this:
iBotPeaches/Apktool#1978

Proposed solution

I manually change the code in tool.py
build_cmd: List[str] = [self.apktool_path, "b", "--force-all", source_dir_path]
to
build_cmd: List[str] = [self.apktool_path, "b", "--force-all", "--use-aapt2", source_dir_path]

However, I think it will be better to add an option to toggle.

Additional context

Noooo

Would you like to submit a pull request for this feature?

I am lazy :P

Btw, Nice work! Hope more people can enjoy this in future. Star is a must!

@yfyau yfyau added the enhancement New feature or request label Jun 30, 2020
@ClaudiuGeorgiu
Copy link
Owner

Hi, thanks for the feature request. The need of --use-aapt2 flag was also reported in #23, so I guess it's time to include it as an option in the next release.

@ClaudiuGeorgiu ClaudiuGeorgiu added the good first issue Good for newcomers label Jun 30, 2020
@GamesDean
Copy link

Hi, thanks for the feature request. The need of --use-aapt2 flag was also reported in #23, so I guess it's time to include it as an option in the next release.

Any update about this issue? I am facing the same problem. Anyway thank you, this tool rocks

@Dado1513 Dado1513 mentioned this issue Apr 12, 2021
10 tasks
@ClaudiuGeorgiu
Copy link
Owner

Added in #84.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants