Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests via GitHub Actions on pull requests #3

Closed
DivineDominion opened this issue May 16, 2024 · 3 comments · Fixed by #5
Closed

Run tests via GitHub Actions on pull requests #3

DivineDominion opened this issue May 16, 2024 · 3 comments · Fixed by #5
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DivineDominion
Copy link
Contributor

While I'm working on this locally, I run unit tests compulsively all the time.

For PR's, we better double-check with CI like GitHub Actions.

@DivineDominion DivineDominion added good first issue Good for newcomers help wanted Extra attention is needed labels May 16, 2024
@ikelax
Copy link
Contributor

ikelax commented May 21, 2024

I want to work on this. Do you already have further steps in mind?

@DivineDominion
Copy link
Contributor Author

Nothing special. There are GitHub action templates that should do the trick. For now, we should end up running swift test. That'll compile and run tests and report the result.

Once other platforms are introduced in e.g. #2 we would need to create a "test matrix". But we'll figure that out once we get there.

@DivineDominion
Copy link
Contributor Author

@ikelax You can take liberal inspiration from https://github.com/ChimeHQ/ChimeKit -- and if the Actions work, also uncomment the "Build" badge in the README that I prepared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants