Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility between CubicChunks/Fugue/CensoredASM and CubicChunks/Valkyrie on Cleanroom Loader #217

Open
5 tasks done
Toku500 opened this issue Oct 7, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Toku500
Copy link

Toku500 commented Oct 7, 2024

Your CleanroomMC Discord Username

Tokusuiku

Cleanroom Version

Cleanroom-MMC-instance-0.2.3-alpha

Java Version

Java 22

Graphics Card Vendor

NVidia

Bug Report

Incompatibility between CubicChunks/Fugue/CensoredASM and CubicChunks/Valkyrie on Cleanroom Loader when repeating those steps :

CensoredASM
Crash at startup when CubicChunks and Fugue are enabled inside a Cleanroom Loader instance: https://mclo.gs/e8Y8SJ4

Valkyrie
Crash at startup when CubicChunks, Redcore and Valkyrie are enabled inside a Cleanroom Loader instance : https://mclo.gs/MSECQh0

Tested all mods together with Fugue 0.15.10 enabled/disabled and scalar-1.12.2-2.11.1 Enabled/Disabled

Mod List

CubicChunks + CensoredASM+ Fugue ( Enabling or Disabling scalar-1.12.2-2.11.1 do not affect the outcome )

Or

CubicChunks + RedCore + Valkyrie ( Enabling or Disabling scalar-1.12.2-2.11.1 do not affect the outcome )

Fugue 0.15.10
Scalar 2.11.1

MMC Instance Notes

Works perfectly fine on Forge but crashing on startup when using Cleanroom Loader instead.

Final Checklist

  • I have searched the issues and haven't found a similar issue.
  • I have read the known incompatibilities and this is not related to one of those.
  • I have installed Fugue and it does not fix this issue.
  • I am using experimental branch and have installed Scalar and it does not fix this issue.
  • I am running a test build from Cleanroom Github Actions. (Or, if I've compiled it myself I plan to fix the issue)
@Toku500
Copy link
Author

Toku500 commented Oct 7, 2024

( Same issue with Fugue 0.16.3 )

@michaelsebero
Copy link

@ZZZank
Copy link
Contributor

ZZZank commented Oct 8, 2024

The first crash log revealed a duplicate class definition problem from CubicChunk, and does not seem to be related to CensoredASM by any means, please send latest.log

Caused by: java.lang.LinkageError: loader net.minecraft.launchwrapper.LaunchClassLoader @238d68ff attempted duplicate class definition for io.github.opencubicchunks.cubicchunks.core.CubicChunksConfig. (io.github.opencubicchunks.cubicchunks.core.CubicChunksConfig is in unnamed module of loader net.minecraft.launchwrapper.LaunchClassLoader @238d68ff, parent loader 'app')

The second crash is due to Valkyrie, whose mixin injection failed, I think you should be able to reproduce it without CubicChunk

Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Constant modifier method modifyWindowTitle(Ljava/lang/String;)Ljava/lang/String; in mixins.valkyrie.json:MinecraftMixin from mod unknown-owner failed injection check, (0/1) succeeded. Scanned 0 target(s). Using refmap mixins.valkyrie.refmap.json

@Toku500
Copy link
Author

Toku500 commented Oct 8, 2024

The first crash log revealed a duplicate class definition problem from CubicChunk, and does not seem to be related to CensoredASM by any means, please send latest.log

Caused by: java.lang.LinkageError: loader net.minecraft.launchwrapper.LaunchClassLoader @238d68ff attempted duplicate class definition for io.github.opencubicchunks.cubicchunks.core.CubicChunksConfig. (io.github.opencubicchunks.cubicchunks.core.CubicChunksConfig is in unnamed module of loader net.minecraft.launchwrapper.LaunchClassLoader @238d68ff, parent loader 'app')

The second crash is due to Valkyrie, whose mixin injection failed, I think you should be able to reproduce it without CubicChunk

Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Constant modifier method modifyWindowTitle(Ljava/lang/String;)Ljava/lang/String; in mixins.valkyrie.json:MinecraftMixin from mod unknown-owner failed injection check, (0/1) succeeded. Scanned 0 target(s). Using refmap mixins.valkyrie.refmap.json

https://mclo.gs/X3YYYXG latest.log for the first one

@Rongmario Rongmario added the bug Something isn't working label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants